Commit f93ae872 authored by astian's avatar astian Committed by Jean-Baptiste Kempf

Squelch potential buffer overflow warning

GCC 7.3 points out that a buffer of size PATH_MAX is being written to
with data that can theoretically overflow (a string of maximum size
PATH_MAX plus other constant-size strings).  Fix this by replacing
sprintf with snprintf.
Signed-off-by: default avatarastian <astian@elude.in>
Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <jb@videolan.org>
parent d7f5aaae
Pipeline #9157 passed with stage
in 1 minute and 28 seconds
......@@ -320,7 +320,19 @@ static int init_cache_dir( dvdcss_t dvdcss )
return -1;
}
sprintf( psz_tagfile, "%s/" CACHE_TAG_NAME, dvdcss->psz_cachefile );
i_ret = snprintf( psz_tagfile, PATH_MAX, "%s/" CACHE_TAG_NAME,
dvdcss->psz_cachefile );
if ( i_ret < 0 || i_ret >= PATH_MAX)
{
if ( i_ret < 0)
print_error( dvdcss, "failed to compose cache directory tag path");
else
print_error( dvdcss, "cache directory tag path too long: %s/" CACHE_TAG_NAME,
dvdcss->psz_cachefile );
dvdcss->psz_cachefile[0] = '\0';
return -1;
}
i_fd = open( psz_tagfile, O_RDWR|O_CREAT, 0644 );
if( i_fd >= 0 )
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment