GitLab

Alexander Strasser authored Nov 01, 2014 and Diego Biurrun committed Nov 02, 2014

Avoid error handling where it is not needed.
Signed-off-by: Alexander Strasser <eclipse7@gmx.net>
Signed-off-by: Diego Biurrun <diego@biurrun.de>

There is a buffer in the global dvdcss struct that can be used instead.

Otherwise creating the tag would fail on first invocation of libdvdcss and
the tag would only be created upon the second invocation.

Under Windows the parameter is passed on to DeviceIoControl()
as a non-const parameter.

None of the supported development environments on Windows need it.

Jerome Duval authored Oct 31, 2014 and Diego Biurrun committed Oct 31, 2014

Adapted from a Haiku ports packaging patch.

The ASPI access method is only relevant on Windows 9x versions where no
alternative exists. However, These Windows versions are obsolete since a
long time and have no more real world usage. Also, the ASPI code is ugly
and a maintenance burden.

The latter is the more common idiom, the former reads weird.

This silences a complaint from the MSVC code analyzer.

This silences a complaint from the MSVC code analyzer.

This silences related complaints from MSVC about those function names.

This prevents a possible NULL pointer dereference further along.

This fixes some related incompatible pointer type warnings.

On non-Linux platform dvd_region uses static functions from ioctl.c,
so just linking against the object file is not enough.

C99 reserves identifier names starting with an underscore at the file level.