Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • dav1d dav1d
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLAN
  • dav1ddav1d
  • Issues
  • #343
Closed
Open
Created Jun 30, 2020 by Dale Curtis@dalecurtisContributor

The latest release of nasm (2.15.01) emits errors and warnings on dav1d assembly code.

One error and these three warnings to be precise: -Wmacro-params-legacy -Wmacro-params-multi -Wlabel-orphan

Still digging in to see if this is a configuration issue.

Here a sample error:

nasm -DPIC -felf64 -W+error=all -Wno-macro-params-legacy -Wno-macro-params-multi -Wno-label-orphan -P ../../third_party/dav1d/config/linux/x64/config.asm -I../../third_party/dav1d/libdav1d/src// -I../../third_party/dav1d/config/linux/x64/ -I./ -I../../ -Igen/ -DSTACK_ALIGNMENT=32 -MD obj/third_party/dav1d/dav1d_asm/mc_sse.o.d -o obj/third_party/dav1d/dav1d_asm/mc_sse.o ../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm
../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm:5923: error: label `PREP_8TAP_HV_LOAD' inconsistently redefined
../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm:2757: ... from macro `PREP_8TAP_HV' defined here

-Wmacro-params-legacy:

../../third_party/dav1d/libdav1d/src/x86/cpuid.asm:47: warning: dropping trailing empty parameter in call to multi-line macro `DEFINE_ARGS_INTERNAL' [-w+macro-params-legacy]
../../third_party/dav1d/libdav1d/src//ext/x86/x86inc.asm:574: ... from macro `PROLOGUE' defined here

-Wmacro-params-multi:

../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm:5933: warning: multi-line macro `PREP_8TAP_HV_LOAD' exists, but not taking 0 parameters [-w+macro-params-multi]
../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm:2757: ... from macro `PREP_8TAP_HV' defined here

-Wlabel-orphan:

nasm -DPIC -felf64 -W+error=all -Wno-macro-params-legacy -Wno-macro-params-multi -P ../../third_party/dav1d/config/linux/x64/config.asm -I../../third_party/dav1d/libdav1d/src// -I../../third_party/dav1d/config/linux/x64/ -I./ -I../../ -Igen/ -DSTACK_ALIGNMENT=32 -MD obj/third_party/dav1d/dav1d_asm/mc_sse.o.d -o obj/third_party/dav1d/dav1d_asm/mc_sse.o ../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm
../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm:5923: error: label alone on a line without a colon might be in error [-w+error=label-orphan]
../../third_party/dav1d/libdav1d/src/x86/mc_sse.asm:2757: ... from macro `PREP_8TAP_HV' defined here
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking

VideoLAN code repository instance