GitLab

Marvin Scholz authored Sep 26, 2018 and Jean-Baptiste Kempf committed Sep 26, 2018

This library is just a helper and should not be built by default as it
is only used to extract the objects and has no use as stand-alone
library for uses to link to.

The -Wall flag is already set by default, as mesons `warning_level`
defaults to 1, which includes the -Wall flag.

Fix #12

No GNU extensions are used.

Marvin Scholz authored Sep 23, 2018 and Jean-Baptiste Kempf committed Sep 24, 2018

Define `_POSIX_C_SOURCE` to `200112L`, to indicate we want to use
POSIX.1–2001. Additionally remove incorrect definition of
`POSIX_C_SOURCE` (note the lack of underscore at the beginning).
The intention was probably to define `_POSIX_C_SOURCE` which would be
redundant and previously even conflicting with the other version set
previously.
For the has_function check, use the correct value of `200112L`.

Marvin Scholz authored Sep 23, 2018 and Jean-Baptiste Kempf committed Sep 24, 2018

- _REENTRANT and _THREAD_SAFE were taken from the VLC build system
  and have since been removed there, so it seems safe to remove those
  here as well.
- _POSIX_PTHREAD_SEMANTICS is required for POSIX thread flavor of
  threading functions but instead we can define _POSIX_C_SOURCE to a
  value higher than 199506L, when including <pthread.h>, see
  https://docs.oracle.com/cd/E19455-01/806-5257/compile-3/index.html
- __EXTENSIONS__ is used to enable Solaris extensions, as far as I
  know we are not using any.
- _FILE_OFFSET_BITS is already defined to 64 by meson.
- _ISOC99_SOURCE should not be required as we do not support compiling
  with -std c89.
- _ISOC11_SOURCE should not be required as we set -std c11, so we do
  not need any C11 extensions to C99 as we already use C11.
- _POSIX_SOURCE is not required as we already set _POSIX_C_SOURCE to
  a positive integer.
* _XOPEN_SOURCE should not be needed as we already have
  _POSIX_C_SOURCE.
* _XOPEN_SOURCE_EXTENDED should not be required as we do not need any
  X/Open Unix extensions to my knowledge.
* _BSD_SOURCE should not be required as we already set _POSIX_C_SOURCE.
* _SVID_SOURCE should not be required as we already set _POSIX_C_SOURCE.

This currently doesn't get installed at all.

Once meson 0.48 is required, this should be changed back to use the
optimization option instead. (See #1)

With minor contributions from:
 - Jean-Baptiste Kempf <jb@videolan.org>
 - Marvin Scholz <epirat07@gmail.com>
 - Hugo Beauzée-Luyssen <hugo@videolan.org>