inconsistent name for tracksMediaInformation key
looks like no-one is using the dictionary returned by [VLCMediaPlayer.media tracksinformation].
At least I found an inconsistency with one of the Key constants.
VLCMedia.h Line 372:
extern NSString *const VLCMediaTracksInformationSourceAspectRatioDenominator;
vs. VLCMedia.h Line 432:
* \see VLCMediaTracksInformationSourceAspectDenominator
and VLCMedia.m Line 643:
NSString *const VLCMediaTracksInformationSourceAspectDenominator = @"sar_den"; // NSNumber
Also documentation tells, what is written in VLCMedia.h Line 432. When trying to use VLCMediaTracksInformationSourceAspectRatioDenominator compiler is fine but you get an linker error (undefined symbol) because the symbol is defined as VLCMediaTracksInformationSourceAspectDenominator.
Cleaning it up (either change the name of the symbol or fix the export declaration in the header) could reduce some puzzling when using VLCKit. I won’t commit a change, as I do not know, which is your preferred way of fixing it to keep the names consistent.
Looking at VLCMediaTracksInformationFrameRateDenominator would suggest to me, that the declaration in the header is fine and the documentation and the definition should adopt the naming scheme of the declaration.