Skip to content

LibVLCSharp
LibVLCSharp
Commit a1d749ff authored by Martin Finkel's avatar Martin Finkel
Browse files
Options

Core: Fix size_t C# interop 

ulong is not always correct for size_t marshaling. Use UIntPtr for P/Invoke and cast to uint or ulong depending on bitness.

Closes #217
parent 168f5fe8
Hide whitespace changes
Inline Side-by-side
Showing with 38 additions and 22 deletions
LibVLCSharp/Shared/Helpers/MarshalUtils.cs
View file @ a1d749ff
......@@ -209,7 +209,6 @@ namespace LibVLCSharp.Shared.Helpers
/// <summary>
/// Generic marshalling function to retrieve structs from libvlc by reading from unmanaged memory with offsets
/// This supports ulong libvlc signatures.
/// </summary>
/// <typeparam name="T">Internal struct type</typeparam>
/// <typeparam name="TU">publicly facing struct type</typeparam>
......@@ -220,17 +219,25 @@ namespace LibVLCSharp.Shared.Helpers
/// <param name="releaseRef">Native libvlc call: release the array allocated with the getRef call with the given element count</param>
/// <returns>An array of publicly facing struct types</returns>
internal static TU[] Retrieve<T, TU>(IntPtr nativeRef, ArrayLongOut getRef, Func<IntPtr, T> retrieve,
Func<T, TU> create, Action<IntPtr, ulong> releaseRef)
Func<T, TU> create, Action<IntPtr, UIntPtr> releaseRef)
where T : struct
where TU : struct
{
var arrayPtr = IntPtr.Zero;
ulong countLong = 0;
var countSizeT = UIntPtr.Zero;
var count = 0;
try
{
countLong = getRef(nativeRef, out arrayPtr);
var count = (int)countLong;
{
countSizeT = getRef(nativeRef, out arrayPtr);
if (IntPtr.Size == 4)
{
count = Convert.ToInt32((uint)countSizeT);
}
else if (IntPtr.Size == 8)
{
count = Convert.ToInt32((ulong)countSizeT);
}
if (count == 0)
{
......@@ -258,7 +265,7 @@ namespace LibVLCSharp.Shared.Helpers
{
if(arrayPtr != IntPtr.Zero)
{
releaseRef(arrayPtr, countLong);
releaseRef(arrayPtr, countSizeT);
arrayPtr = IntPtr.Zero;
}
}
......@@ -266,7 +273,7 @@ namespace LibVLCSharp.Shared.Helpers
/// <summary>
/// Generic marshalling function to retrieve structs from libvlc by reading from unmanaged memory with offsets
/// This supports ulong libvlc signatures and an additional enum configuration parameter.
/// This supports an additional enum configuration parameter.
/// </summary>
/// <typeparam name="T">Internal struct type</typeparam>
/// <typeparam name="TU">publicly facing struct type</typeparam>
......@@ -279,18 +286,27 @@ namespace LibVLCSharp.Shared.Helpers
/// <param name="releaseRef">Native libvlc call: release the array allocated with the getRef call with the given element count</param>
/// <returns>An array of publicly facing struct types</returns>
internal static TU[] Retrieve<T, TU, TE>(IntPtr nativeRef, TE extraParam, CategoryArrayOut<TE> getRef, Func<IntPtr, T> retrieve,
Func<T, TU> create, Action<IntPtr, ulong> releaseRef)
Func<T, TU> create, Action<IntPtr, UIntPtr> releaseRef)
where T : struct
where TU : struct
where TE : Enum
{
var arrayPtr = IntPtr.Zero;
ulong countLong = 0;
var countSizeT = UIntPtr.Zero;
var count = 0;
try
{
countLong = getRef(nativeRef, extraParam, out arrayPtr);
var count = (int)countLong;
{
countSizeT = getRef(nativeRef, extraParam, out arrayPtr);
if (IntPtr.Size == 4)
{
count = Convert.ToInt32((uint)countSizeT);
}
else if (IntPtr.Size == 8)
{
count = Convert.ToInt32((ulong)countSizeT);
}
if (count == 0)
{
#if NETSTANDARD1_1 || NET40
......@@ -317,16 +333,16 @@ namespace LibVLCSharp.Shared.Helpers
{
if (arrayPtr != IntPtr.Zero)
{
releaseRef(arrayPtr, countLong);
releaseRef(arrayPtr, countSizeT);
arrayPtr = IntPtr.Zero;
}
}
}
// These delegates allow the definition of generic functions with [OUT] parameters
internal delegate ulong CategoryArrayOut<T>(IntPtr nativeRef, T enumType, out IntPtr array) where T : Enum;
internal delegate UIntPtr CategoryArrayOut<T>(IntPtr nativeRef, T enumType, out IntPtr array) where T : Enum;
internal delegate uint ArrayOut(IntPtr nativeRef, out IntPtr array);
internal delegate ulong ArrayLongOut(IntPtr nativeRef, out IntPtr array);
internal delegate UIntPtr ArrayLongOut(IntPtr nativeRef, out IntPtr array);
/// <summary>
/// Turns an array of UTF16 C# strings to an array of pointer to UTF8 strings
......@@ -508,4 +524,4 @@ namespace LibVLCSharp.Shared.Helpers
}
public Type Type { get; private set; }
}
}
\ No newline at end of file
}
LibVLCSharp/Shared/LibVLC.cs
View file @ a1d749ff
......@@ -118,11 +118,11 @@ namespace LibVLCSharp.Shared
[DllImport(Constants.LibraryName, CallingConvention = CallingConvention.Cdecl,
EntryPoint = "libvlc_media_discoverer_list_get")]
internal static extern ulong LibVLCMediaDiscovererListGet(IntPtr libVLC, MediaDiscovererCategory category, out IntPtr pppServices);
internal static extern UIntPtr LibVLCMediaDiscovererListGet(IntPtr libVLC, MediaDiscovererCategory category, out IntPtr pppServices);
[DllImport(Constants.LibraryName, CallingConvention = CallingConvention.Cdecl,
EntryPoint = "libvlc_media_discoverer_list_release")]
internal static extern void LibVLCMediaDiscovererListRelease(IntPtr ppServices, ulong count);
internal static extern void LibVLCMediaDiscovererListRelease(IntPtr ppServices, UIntPtr count);
[DllImport(Constants.LibraryName, CallingConvention = CallingConvention.Cdecl,
EntryPoint = "libvlc_dialog_set_callbacks")]
......@@ -130,11 +130,11 @@ namespace LibVLCSharp.Shared
[DllImport(Constants.LibraryName, CallingConvention = CallingConvention.Cdecl,
EntryPoint = "libvlc_renderer_discoverer_list_get")]
internal static extern ulong LibVLCRendererDiscovererGetList(IntPtr libVLC, out IntPtr discovererList);
internal static extern UIntPtr LibVLCRendererDiscovererGetList(IntPtr libVLC, out IntPtr discovererList);
[DllImport(Constants.LibraryName, CallingConvention = CallingConvention.Cdecl,
EntryPoint = "libvlc_renderer_discoverer_list_release")]
internal static extern void LibVLCRendererDiscovererReleaseList(IntPtr discovererList, ulong count);
internal static extern void LibVLCRendererDiscovererReleaseList(IntPtr discovererList, UIntPtr count);
[DllImport(Constants.LibraryName, CallingConvention = CallingConvention.Cdecl,
EntryPoint = "libvlc_retain")]
......@@ -731,4 +731,4 @@ namespace LibVLCSharp.Shared
internal delegate void LogCallback(IntPtr data, LogLevel logLevel, IntPtr logContext, IntPtr format, IntPtr args);
#endregion
}
\ No newline at end of file
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment