- 29 Apr, 2021 21 commits
-
-
-
such that they are ordered per increasing amount of info printed: help -> longhelp (adds plugins) -> fullhelp (adds longhelptext)
-
move it from under the stream filter subcat to the demux subcat, which surely makes more sense.
-
When core options are printed in terminal help output, category headings are only printed when a 'category hint' entry is encountered in the list. As things were, some hints were missing or otherwise misplaced, such that some options appeared mis-categorised. The preferences GUI interface is unaffected. This commit corrects the problem. The problem specifically consists of the following component issues: - When we get to INPUT category options, no hint is given. The input cat starts with a section called "track settings" and you can see that this gets printed immediately after the section "overlays" from the subpictures category; Thus it appears as though most input options are actually subpicture options. - Further down, the input sub-categories "vcodec" and "access" both have hints (of "decoders" and "input" respectively), resulting in headings being printed. But, for the latter, the title and longtext description actually reflects a heading that should apply to the entire input category. 'Decoders' as a heading for the VCodec sub-cat is wrong, and the longtext (CODEC_CAT_LONGTEXT) is worded to speak of one single option only. - Further still, you may find a "Performance options" section heading, but its location varies. It should appear under "Miscellaneous", but if there are no options to display under it (i.e. when not showing advanced options, and not on Windows), it thus appears instead under the "Playlist" category heading. (Update: this point is somewhat outdated now with --advanced having been removed in v4.0 dev subsequent to the original creation of this commit). - Next, when we get to the interface category, again no hint is given. The playlist category above it ends with the "services-discovery" option, but no title gets printed for the interface category, so it is directly followed by the interface options, starting with "verbose". Eventually we get a hint for the hotkeys interface sub-category and get a new heading. - Finally, we get a '-1' category, hiding some options from the GUI. This illogially includes options like --help along with bookmark and bookmark-hotkey options. Furthermore there is no hint, thus all of these are appearing under the "hotkeys" heading, specifically in fact the "Jump sizes" section. This commit addresses these issues by: - Moving the input category hint up to where that category actually starts. - Moving the SUBCAT_INPUT_VCODEC subcat block to a more logical position. - Changing the "Decoders" hint that starts the access/codec input options to "Input access and codecs" and rewriting the longtext. - Removing MISC_CAT_LONGTEXT which didn't make sense in context. - Changing the "Miscellaneous" hint for the advanced category to "Advanced" matching the category title in the (Qt) GUI. - Moving the "--bookmark1", "--bookmark2", etc block of options that relate to playlists up to the general playlist category, though retaining the -1 subcat to ensure that they are still correctly hidden in the GUI. (the individual options need hiding as they are separately found and included in the big hotkey table control). - Adding a hint for the interface category, so we get a heading now. (This re-used the already existing longtext). - Clarifying the comment (now duplicated) about hiding options with the -1 cat/subcat hack, by mentioning this relates to the GUI. - Adding a "Bookmarks" section heading for bookmark hotkey options, to separate these from the previous "Jump Sizes" section. - Adding a "Miscellaneous" hint before the block at the end which includes the help output options to create a new heading, separating this stuff from the previous hotkeys (interface sub-cat) heading. - Moving the -1 cat/subcat that was incorrectly above the bookmark-hotkey options down to this misc block. Also, I've moved the module name up to the top (clearer IMO).
-
-
fixes selected index shifting whenever a album is played
-
fixes #25602
-
-
previously RoundImage was implemented in QML using Opacitymask which was slow, new implementation done in cpp using QQuickPaintedItem is around ~5x faster
-
-
-
add them using MediaCover.imageOverlay property whenever required
-
to VideoGridItem, they are only used with this widget Improves creation time of GridItem
-
to VideoGridItem, they are only used with this widget Improves creation time of GridItem
-
-
this can be helpfull to move different items out of GridItem
-
-
-
-
As discussed in MR #11 ([1]), `qtr()` is only meant to be used with static strings, not constants or variables. Translation occurs through pointing xgettext at the `qtr` keyword to find strings (as an alternative to `_()`, taking into account the common need to convert to a Qt `String` type). Thus use with anything other than a static string relies upon xgettext having to recognise and ignore instances that do not actually wrap static strings, which is considered to be wrong, even if it happens to work. Accordingly here `qfut()` has been introduced. This is to be used in cases where `qtr()` was incorrectly used around constant identifiers and variables (i.e. where a combination of `qfu()` plus translation is needed, with the string being defined elsewhere (with `N_()`)). The `qtr()` macro itself now acts as a wrapper to `qfut()` for cases where the parameter is in fact a static string, thus additionally marking it to be picked up by xgettext, unlike other use of `qfut()`. Notes for future readers, the set of macro names reflect: - `qfu()`: Creates a Qt `String` type from UTF-8 ('f'=from, 'u'=utf8). - `qfue()`: `qfu()` with ampersand escaping ('e'=escape). - `qfut()`: `qfu()` with translation ('t'=translation). - `qtu()`: Qt `String` to UTF-8 ('t'='to', 'u'=utf8). - `qtr()`: this is a wrapper for `qfut()`, acting as an xgettext marker, similar to `_()` except returning a Qt `String`. ('tr'=translate). [1]: videolan/vlc!11 -
the memory allocations were released in the error path but not the success path.
-
- 28 Apr, 2021 11 commits
-
-
-
Instead of the rather weird, effectively commented-out code, remove it and add a comment explaining why xmlCleanupParser can't be called for future reference.
-
-
Now that the needed sample is in the repository, there is no reason to keep the test disabled.
-
Instead of trying it to fetch from a no longer existing location on the samples server, add a variation of the file to the repository.
-
This file is not referenced anywhere in the source code and the URL where it tries to fetch it from is not found.
-
On macOS the qt interface does not spawn a thread but instead runs on the main thread, so taking the locks here would lead to a deadlock.
-
-
Z:\builds\videolan\vlc\extras\package\win32\msi\product.wxs(128) : error LGHT0103 : The system cannot find the file 'vlc-4.0.0-dev\README.txt'.
-
Stream re-use could never happen, as p_stream->p_es is always NULL here, as implied by the earlier check: if ( p_stream->p_es == NULL && !p_stream->b_finished ) To fix that, the check for a non-null p_stream->p_es is removed. Partially fixes #25186
-
This avoids warnings about harmful delay when compiling the test with GCC
-
- 27 Apr, 2021 8 commits
-
-
Change the update label text to "Check for Updates..." to be consistent with what the Qt interface uses and what other macOS apps are using too. Fix #25670
-
we do not want to be doing a 'starts with' check in these cases, they should be an equality check
-
The type is actually vlc_tick_t, so in order to prevent confusion, it should be named accordingly.
-
-
-
-
-
We can't assume OSStatus is always an int.
-
