- 10 May, 2021 8 commits
-
-
in audiobargraph it's never even initialised. it is unnecessary since `i_pos` being `-1` suffices to signal absolute positioning mode within the module, and the copy into `p_spu->b_absolute` gets overwritten a few lines further down.
-
i believe that this is an entirely non-functional change upon the belief that this property is not used in absolute mode (and thus is actually rather pointlessly being set). i'm just changing it out of pedantic correctness. the top-right setting did not match the positioning done by absolute mode (see `SpuRegionPlace()` in vout_subpictures.c), and was inconsistent with what was set in marq and rss plugins. this originates for logo with 5a33cfd2 whereby the author decided for no apparent reason to change the property to reflect the previous position default of 6 (top-right). this seems to have then been inherited through copy & paste i guess into the creation of audiobargraph_v in 0e3ec227.
-
for consistency with options of the other spu plugins. the meaning of the range of values appears to be identical, the only difference was the option name.
-
note that in the logo case, an extra note is added to the end of the pos x/y longtext, requiring an override. position texts tweaked to make generic.
-
... bringing better consistency and reducing translator burden. some simplified by removing unnecessary plugin name. fixed typo of "eg" instead of "e.g.", and inconsistent use of ',' vs. ';' in same text.
-
- offsets can be used for both absolute and relative positioning (except offsetting from center). - the `i_pos` attribute holds indication of absolute mode, not just relative, which was incorrectly stated in marq and rss. (note that logo and bargraph have an `i_absolute` attribute, but this is actually unneeded and can be removed later). labels are synchronised across plugins to reduce translator burden and improve consistency.
-
the default value (`-1`) did not correspond to any choice list entry, thus causing buggy behaviour wrt. saving preferences. (which is very noticeable in a new preferences interface i have built). this adds the `-1` choice list entry for 'absolute' to fix that. --- i questioned whether adding such an entry was correct in terms of it possibly being redundant alongside top-left + offsets. i noted that there is a specific code path for absolute mode involving marking the spu as positioned absolutely. i am not certain whether or not this is actually redundant for these plugins, and thus did not implement the alternative solution of ripping out those absolute mode bits and changing the default to `5` (top-left). my understanding, from spending time researching git history and the current codebase (without a great understanding of the spu code yet though) is that the absolute property comes into play when there are multiple spus, being to do with prevention of overlaps. absolute mode forces position, whilst non-absolute allows moving spus to fix overlap.
-
Hugo Beauzée-Luyssen authored
-
- 09 May, 2021 15 commits
-
-
Tidy up the struct and comments, and also remove redundant forward declarations.
-
I can't think of a use case for this ever being refcounted. It made more sense back when it held the actual instance, but the platform/surface is only ever going to be used by whatever also owns the vout_window_t.
-
With the removal of the actual vulkan instance from this abstraction in 883a865a, calling this "instance" is confusing and misleading. It should be called "platform", because the only thing the abstraction is designed to contain is platform-specific state and operations. Rename it, and the associated type, for clarity. This frees up the name `vlc_vk_t` to be used for an actual Vulkan instance, if we ever decide we need one in the future. (e.g. for GPU filters)
-
This affects OpenGL.
-
Supports both GL and GLES2, configurably.
-
Needed for OpenGL API support, at least on versions of libplacebo prior to v3.128. It's worth pointing out that this logic is therefore only temporary - once the libplacebo version is bumped past v3.128, this can be removed again. This commit only adds the API, with the OpenGL implementation coming in a following commit.
-
-
The old settings names were not properly namespaced. Since this is technically a new vout, use the opportunity to break existing configurations in order to namespace all of the settings.
-
Rebases vulkan/display.c ontop of the new API-agnostic libplacebo GPU abstraction module. This opens up libplacebo/display.c to work with API backends other than Vulkan. Note: this has the side effect of bumping up the minimum libplacebo dependency, because now the libplacebo vout is always compiled when libplacebo is available. On the plus side, however, it simplifies the configure check. That said, 1.7.0 is from 2018, and packaged everywhere (including debian stable). so this should be fine.
-
This lifts the v1.7.0 dependency from the vulkan-specific check out into the general libplacebo pkgconfig check, a change which is required for the following refactor of vulkan/display.c into libplacebo/display.c. A separate dependency for v0.5 is no longer needed, since it's very old and no longer shipping anywhere (including debian stable). Therefore, simplify the logic rather than recreating it exactly.
-
This will help disentangle the libplacebo-based vout from the individual pl_gpu providers (vulkan, opengl, etc.) Rename the existing vlc_placebo_Create helper to vlc_placebo_CreateContext to avoid symbol collision.
-
This will be reused by the other libplacebo components, and in particular is required to avoid symbol collisions.
-
This is no longer used by anything, as the vulkan code no longer depends directly on libplacebo.
-
This was deprecated in libplacebo git master, but mistakenly removed entirely for some (untagged) versions (specifically, v3.120 through v3.137). As such, this commit fixes build errors for those versions. (And gets rid of a deprecation warning for v3.138+)
-
never used since introduction of the module in 51b38743 feedback in MR suggested deleting rather than obsoleting since it was never in v3.0, only in 4.0-dev.
-
- 08 May, 2021 10 commits
-
-
Tristan Matthews authored -
-
fix #25595
-
-
-
-
-
This class can be useful to retrieve composed thumbnails for groups, playlists and genres. It supports a few options like custom size, count and division type.
-
This is useful when we only want to return a cached item.
-
fix #25668
-
- 07 May, 2021 7 commits
-
-
fix #25663
-
it confused me in the past when I tried `vlc -p pulse` and it came back with an error stating that no matching module was found, and to look in the list generated by --list, when that does in fact contain a module with that name. the problem is that the module has no options (nor pulsesrc/pulselist), and the underlying logic is geared primarily towards --full-help/--longhelp output which deliberately skips over such modules. i have finally looked into this and fixed the confusing behaviour by avoiding skipping over modules when in search mode, so now we output minimal details about such modules along with a statement that it has no options when looking up modules, but continue to skip over them in --full-help/--longhelp output. old output: ``` lyndon@desktop ~$ vlc -p pulse VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-15406-g183c8d99) No matching module found. Use --list or --list-verbose to list available modules. ``` new output: ``` lyndon@desktop ~$ vlc -p pulse VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-15407-g19c204c671) Pulseaudio audio output (pulse) This module has no options. PulseAudio input (pulsesrc) Pass pulse:// to open the default PulseAudio source, or pulse://SOURCE to open a specific source named SOURCE. This module has no options. Audio capture (PulseAudio) (pulselist) This module has no options. ```
-
Hugo Beauzée-Luyssen authored
Fix #25555
-
Hugo Beauzée-Luyssen authored
Refs #25555
-
-
libvlc_media_new_callbacks does not set imem-get and imem-release. Because of this, the following logs imem Error: Invalid get/release function pointers are confusing users. This commit aligns behavior with imem-access.c which also returns VLC_EGENERIC silently for missing read_cb.
-
Thomas Guillem authored
Fixes deprecated usage of libvlc_media_parse.
-
