GitLab

Romain Vimont authored Nov 20, 2018 and Thomas Guillem committed Nov 23, 2018

Like unique_ptr, make the operator bool() explicit, so that it is only
called implicitly when the value may be "contextually converted to bool"
(if, while, etc.).
Suggested-by: Filip Roséen <filip@atch.se>
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Don't modify the host, used by sub items, even if it needs to be resolved.

vlc_smb2_resolve() now returns the resolved host instead of modifying the host
argument.

The tools are already built, so no need to fiddle with Qt's internals to
rebuild it. Doing so tend to cause problems when building upon
subsequent builds.
We need to install mkspecs so that qmake knows where to find the modules
we build in other Qt related contribs

Which deprecates previous patch

This removes nonsensical arithmetic with pointer representation.

They are only printed in debug at start-up.

 - Do not assume 16-bits unaligned reads work.
 - Do not assume little endianess.
 - Do not assume ASCII strings.

(only affects test cases)

This value is not used.

Lukas Bergdoll authored Nov 17, 2018 and Rémi Denis-Courmont committed Nov 20, 2018

Acked-by: Shaleen Jain <shaleen@jain.sh>
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

This should sort properly on Windows and any other platform without
qsort_r(). It does _not_ fix any potential issues on any platforms with
an incompatible qsort_r() prototype (such as FreeBSD < 13).

Win32 qsort_s() is _not_ equivalent to POSIX.next/GNU qsort_r().
The order of arguments to the comparison callbacks differ.

This would cause a compile-time warning and a crash at run-time.
This change will break the build instead; this will be fixed later.

Romain Vimont authored Nov 16, 2018 and Thomas Guillem committed Nov 20, 2018

If vlc_vector_push() returns false, then we keep ownership of the item,
so we must release it.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Romain Vimont authored Nov 16, 2018 and Thomas Guillem committed Nov 20, 2018

Disable vlc_player_vout_OSDMessage() calls for tests the same way as the
other player calls, and silent unused variable warnings.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

This may help with performance and avoid an issue when the render target is
also an input texture for another pipeline.

In case the OMSetRenderTargets() is done elsewhere in the code.