1. 18 May, 2021 2 commits
  2. 15 May, 2021 6 commits
  3. 13 May, 2021 5 commits
  4. 12 May, 2021 13 commits
  5. 11 May, 2021 2 commits
  6. 10 May, 2021 12 commits
    • Lyndon Brown's avatar
      spu: fix formatting · ae406f9e
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      ae406f9e
    • Lyndon Brown's avatar
      audiobargraph_v: catch negative vfilter x/y · 08de6996
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      ... as done in logo.
      08de6996
    • Lyndon Brown's avatar
      audiobargraph_v: fix overwriting vfilter position · 5fc1af11
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      with the x/y defaults being zero, for video filtering, any specified
      relative position would always be overwritten with absolute positioning
      by a condition check.
      
      this fixes the problem by using `-1` for defaults, as with the logo plugin.
      5fc1af11
    • Lyndon Brown's avatar
      spu(audiobargraph,logo): simplification · 26e31343
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      (non-functional change)
      
      flip of logic from a negative align-[top|left] check to a positive one,
      duplicating order things are done in `SpuRegionPlace()`, for better
      readability.
      
      also, compacted the condition block in the logo case by dropping
      unnecessary braces.
      26e31343
    • Lyndon Brown's avatar
      spu(audiobargraph,logo): fix buggy positioning with video filtering · 6b3c3d33
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      the condition check with the comment "Ignore aligment if a position is
      given for video filter" is meant to force absolute mode if positive x/y
      values are given (in video filtering mode), causing a separate condition
      block to skip calculations for x/y. (it seems x/y offsets from relative
      positions are not supported in video filtering mode).
      
      problematically though, the condition check set the position value to
      `0` instead of `-1`, and the x/y calculation block condition checked
      for a non-zero value, which meant that:
       - center,center relative positioning was not possible (pos=0).
       - if position was set to `-1` (as per default) to signal absolute, and
         x/y were not both positive, the x/y calculation block would set about
         trying to calculate x/y based upon incorrectly reading alignment flags
         from the `-1` position value, thus calculating a bogus position.
      
      this commit fixes these issues by correctly signalling and checking for
      absolute mode.
      6b3c3d33
    • Lyndon Brown's avatar
      spu(audiobargraph,logo): remove useless var · c8410c7d
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      in audiobargraph it's never even initialised.
      
      it is unnecessary since `i_pos` being `-1` suffices to signal absolute
      positioning mode within the module, and the copy into `p_spu->b_absolute`
      gets overwritten a few lines further down.
      c8410c7d
    • Lyndon Brown's avatar
      spu(audiobargraph,logo): fix redundant align attribute · fb15e597
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      i believe that this is an entirely non-functional change upon the
      belief that this property is not used in absolute mode (and thus is
      actually rather pointlessly being set). i'm just changing it out of
      pedantic correctness.
      
      the top-right setting did not match the positioning done by absolute
      mode (see `SpuRegionPlace()` in vout_subpictures.c), and was
      inconsistent with what was set in marq and rss plugins.
      
      this originates for logo with 5a33cfd2
      whereby the author decided for no apparent reason to change the
      property to reflect the previous position default of 6 (top-right).
      
      this seems to have then been inherited through copy & paste i guess
      into the creation of audiobargraph_v in 0e3ec227.
      fb15e597
    • Lyndon Brown's avatar
      audiobargraph_v: rename `transparency` option to `opacity` · 1482a9d0
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      for consistency with options of the other spu plugins. the meaning of the
      range of values appears to be identical, the only difference was the
      option name.
      1482a9d0
    • Lyndon Brown's avatar
      spu: move common defines to new shared header · 701bb8a6
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      note that in the logo case, an extra note is added to the end of the pos
      x/y longtext, requiring an override.
      
      position texts tweaked to make generic.
      701bb8a6
    • Lyndon Brown's avatar
      spu(audiobargraph_v,logo,marq,rss): sync common option text · 9ed2f419
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      ... bringing better consistency and reducing translator burden.
      
      some simplified by removing unnecessary plugin name.
      
      fixed typo of "eg" instead of "e.g.", and inconsistent use of ','
      vs. ';' in same text.
      9ed2f419
    • Lyndon Brown's avatar
      spu(audiobargraph_v,logo,marq,rss): fix poor positioning text/docs · 00fc2403
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
       - offsets can be used for both absolute and relative positioning (except
         offsetting from center).
       - the `i_pos` attribute holds indication of absolute mode, not just
         relative, which was incorrectly stated in marq and rss. (note that
         logo and bargraph have an `i_absolute` attribute, but this is actually
         unneeded and can be removed later).
      
      labels are synchronised across plugins to reduce translator burden and
      improve consistency.
      00fc2403
    • Lyndon Brown's avatar
      spu(audiobargraph_v,logo,marq,rss): fix missing choice list entry · 16a61233
      Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      the default value (`-1`) did not correspond to any choice list entry,
      thus causing buggy behaviour wrt. saving preferences. (which is very
      noticeable in a new preferences interface i have built).
      
      this adds the `-1` choice list entry for 'absolute' to fix that.
      
      ---
      
      i questioned whether adding such an entry was correct in terms of it
      possibly being redundant alongside top-left + offsets. i noted that
      there is a specific code path for absolute mode involving marking the
      spu as positioned absolutely. i am not certain whether or not this is
      actually redundant for these plugins, and thus did not implement the
      alternative solution of ripping out those absolute mode bits and
      changing the default to `5` (top-left).
      
      my understanding, from spending time researching git history and the
      current codebase (without a great understanding of the spu code yet
      though) is that the absolute property comes into play when there are
      multiple spus, being to do with prevention of overlaps. absolute mode
      forces position, whilst non-absolute allows moving spus to fix
      overlap.
      16a61233