GitLab

This fixes the warning: "Buddy assignment is not a valid widget" caused
by referencing an invalid widget as buddy for the mmdevice label.

It uses AOUT_VOLUME_DEFAULT which is defined in vlc_aout.h

Fix Windows build (conflict with EndTask).

The "subtree added" and "preparse ended" events are now managed outside
the input item (respectively by the input thread and preparser
callbacks).

Remove these events which are now unused.

Now that the code has been adapted to receive "subtree added" and
"preparse ended" events from the input thread and preparser callbacks,
do not trigger the events on the input item anymore.

Replace listeners on the input item by input thread callbacks.

Add parameters for callbacks and user data so that the caller may
receive input thread events (e.g. "subtree added").

Replace listeners on the input item by input thread callbacks.

Replace listeners on the input item by preparser callbacks (for
preparsing) and input thread callbacks (for normal playback).

Replace listeners on the input item by preparser callbacks (for
preparsing) and input thread callbacks (for normal playback).

After a preparsing, the preparser may request to fetch art, and trigger
the "preparse end" event only after the art have been fetched.

For that purpose, the fetcher and the preparser were highly coupled: the
fetcher was aware of a "preparse status", and was responsible to notify
"preparse ended" on the input item when necessary.

In order to make the fetcher more independant of the preparser, make the
preparser trigger the "preparse ended" event when it is notified of the
"fetch ended" event.

This also paves the way to remove preparsing events on the input item
directly.

Notify "fetch ended" in callbacks.

This will allow to move the "preparse ended" trigger from the fetcher to
the preparser, and make the fetcher more independant.

The input thread used by the preparser is not exposed to the caller.
Add a "callbacks" parameter to receive preparsing events.

Subitems do not belong to an input item: they are created only to fire
an event, then destroyed immediately. Thus, the detection of subitems is
more related to a specific preparsing task than to the item itself.

Therefore, notify the detection of subitems on the input thread, so that
we could eventually remove the vlc_InputItemSubItemTreeAdded event on
the input item.

Some input event structs contain enums, whose values can be accessed
globally in C, but need a qualified access in C++. Since these enums are
defined inside unamed union and structs, there was no way to use them
from C++ code.

To avoid the problem, declare named structs for every event type
requiring more than one field.

A way to speed up the preparsing consists in preparsing several inputs
in parallel.

For this purpose, make the background worker (used by the preparser and
fetcher) execute tasks from (possibly) several threads.

Apart from adding a new field "max_threads" in the
background_worker_config structure, the background worker API is kept
unchanged.

Two new options are added to configure the maximum number of threads
used for preparsing and fetching:
 - preparse-threads
 - fetch-art-threads

Filip Roséen authored Jul 17, 2018 and Romain Vimont committed Aug 20, 2018

As there are plans to make the src/misc/background_worker
multithreaded, the preparser must be changed in order to support
having several tasks running in parallel.

These changes accomplishes said goal by moving the relevant
task related data-members from struct input_preparser_t to a new one,
so that each task has its own state.

The INPUT_EVENT_TELETEXT event was unused (or useless for the QT case since the
same teletext code was called from INPUT_EVENT_ES).

The legacy "teletext-es" event is still triggered from input_LegacyEvents()
when processing INPUT_EVENT_ES events.

And always pass the full fmt to ES events (to enable teletext detection).

vlc_medialibrary_module_t can be used by a "media library" module

Devin Heitmueller authored Aug 09, 2018 and François Cartegnie committed Aug 19, 2018

The routine which iterates over the RBSP to process the SEIs
attempts to accommodate the individual parsers not reading all
the bytes (i.e. by reading any remaining bytes before restarting
the loop), as well as detecting if the parser for a given type
read past the end of SEI.  However the implementation does this
by noting the position of the start of the NAL, getting the
position after parsing, and computing the difference.  This does
not take into account that the bitstream parser has a pf_forward
routine to strip out 3-byte emulation.

Hence in cases where an emulation sequence is found, the number
of bytes processed by the parser don't match how many bytes were
actually consumed in the stream.  The failure occurs at the bottom
of the loop where either it fails to read out extra bytes if the
parser didn't process the entire SEI, or aborting prematurely
thinking that the parser processed too many bytes.

To avoid this issue, clone the bitstream into a second instance
which already has the three byte emulation stripped, and use that
with the existing parser routines.

The use case where this problem manifested was a low latency
stream where it failed to find the SEI recovery point because
there was an emulation sequence in the preceding picture timing
SEI section, and this caused the loop to bail out because the
bs_position was past the size of the picture_timing SEI length.
Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

For badges in source lists a NSInlineBezelStyle button should be used
according to the documentation. This greatly improves the look of the
badge, especially in selected state and Dark Aqua.

This is necessary to update the counter badges properly.

The sidebar is now a view based table with autolayout for the cell view
layout. The height follows now as expected the system setting for the
size of sidebar items.