Commit fb15e597 authored by Lyndon Brown's avatar Lyndon Brown Committed by Jean-Baptiste Kempf
Browse files

spu(audiobargraph,logo): fix redundant align attribute

i believe that this is an entirely non-functional change upon the
belief that this property is not used in absolute mode (and thus is
actually rather pointlessly being set). i'm just changing it out of
pedantic correctness.

the top-right setting did not match the positioning done by absolute
mode (see `SpuRegionPlace()` in vout_subpictures.c), and was
inconsistent with what was set in marq and rss plugins.

this originates for logo with 5a33cfd2
whereby the author decided for no apparent reason to change the
property to reflect the previous position default of 6 (top-right).

this seems to have then been inherited through copy & paste i guess
into the creation of audiobargraph_v in 0e3ec227.
parent 1482a9d0
......@@ -393,7 +393,7 @@ static subpicture_t *FilterSub(filter_t *p_filter, vlc_tick_t date)
/* where to locate the bar graph: */
if (p_sys->i_pos < 0) { /* set to an absolute xy */
p_region->i_align = SUBPICTURE_ALIGN_RIGHT | SUBPICTURE_ALIGN_TOP;
p_region->i_align = SUBPICTURE_ALIGN_LEFT | SUBPICTURE_ALIGN_TOP;
p_spu->b_absolute = true;
} else { /* set to one of the 9 relative locations */
p_region->i_align = p_sys->i_pos;
......
......@@ -393,7 +393,7 @@ static subpicture_t *FilterSub( filter_t *p_filter, vlc_tick_t date )
/* where to locate the logo: */
if( p_sys->i_pos < 0 )
{ /* set to an absolute xy */
p_region->i_align = SUBPICTURE_ALIGN_RIGHT | SUBPICTURE_ALIGN_TOP;
p_region->i_align = SUBPICTURE_ALIGN_LEFT | SUBPICTURE_ALIGN_TOP;
p_spu->b_absolute = true;
}
else
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment