All these types and functions are only used by the VLM module
internally, there is no need to expose them publicly.

Now that vlm.c containing the module implmentation has been moved to
modules/vlm/, rename the core file to vlm.c.

VLM uses it, and will be moved to a module.

This prepares moving the remaining parts to a separate module.

Extract Open()/Close() from vlm_New() and vlm_Delete(), to be moved to
the module implementation.

This paves the way to move the implementation to a separate module.

This paves the way to move the implementation to a separate module.

In order to move the VLM implementation to a separate module, move the
instances counter to a separate private struct known only by the core.

The other fields will be moved to a "sys" private to the module in
further patches.

The "constructor" vlm_New() allowed to optionally load a VLM file.
But vlm_New() internally manages a single refcounted instance,
initialized only the first time.

Therefore, if a VLM instance was already created, the VLM file was just
ignored.

To avoid the confusion, load the file using a separate function.

The vlm instance name may be NULL. The documentation (doc/vlm.txt)
states that the "instance_name" parameter is optional.

A vlm_media_sys_t need not be a VLC object.

No message is ever logged for a media.

More than one users reported that they would prefer having a new function to
unselect. Furthermore, having a type and a track of the same type as arguments
feels confusing.

cf. 6f4685be

Note: All libvlc deprecated functions/members will be removed before VLC 4.0
freeze.

Fix the following warning:

../../modules/video_output/wayland/shm.c:266:60: warning: excess elements in struct initializer
  266 |     Close, Prepare, Display, Control, ResetPictures, NULL, NULL,
      |                                                            ^~~~
../../modules/video_output/wayland/shm.c:266:60: note: (near initialization for 'ops')

Before calling ThreadChangeFilters().

No need to pass a value for deinterlacing anymore.

They do the same thing and the string is always used in ThreadChangeFilters no
matter what.

We always call this function under filter lock.

We don't use the control lock anymore (from vout_control_PushBool), just the
filters lock.

Now the interlacing mode change is applied in frame by frame mode.

We don't need to wait when enabling filters, it's OK if we miss the current
frame and apply it in the next loop iteration. The filter changes will
be applied just before the picture is rendered, only once between frames. It is
now done after the control pop deadline, so will eat some of the rendering
time.

We don't use the control lock anymore (from vout_control_PushString), just the
filters lock.

Now the filter changes are applied even in frame by frame mode.

We can do this in the UI thread, the processing is light.
Locking the display_lock doesn't have a big impact on lag as it's only taking
time when reloading a display module, which is very rare.

They don't need to know about it.

It should already be done by opengl_interop_init in case of success.

Fix #25077

on seek or activation, the seek reference point is
inside a segment and if that segment is longer than
buffering duration, it could never start.
(segment start + buffering amount < deadline)

Only 4 modules actually use the Reset Pictures feature to create a new filter
pipeline when they can't handle the source anymore. It's still faster than
closing the module and probing for a new display module.

Alon Sirota authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Alon Sirota authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

All selected subtitles are now downloaded, instead of only one.

Change 'get_first_sel' function to return ALL selected subtitles
instead of only one, and refactored name to 'get_all_sel'.

Change 'download_subtitles' function to iterate over 'get_all_sel'
returned table instead of downloading the only subtitle from old
'get_first_sel'.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>