This avoids small freezes of the UI thread.

Make the list cache use an async task for executing the count() call.

Make the list cache use async tasks to load the data asynchronously (and
notify data changes once available).

This helper will help implementing asynchronous database queries
initiated on the UI thread by list models.

The database queries, initiated by list models, must be executed
asynchronously (on a thread different from the UI thread).

When a list model is destroyed (from the UI thread), some database
queries might still be executing. It would be incorrect for the list
model to wait for them (it would block the UI thread), so they must be
executed on an external thread pool.

Since the queries themselves require the medialib to be executed, they
must not outlive it (or the asynchronous code might crash). Therefore,
the right scope for executing asynchronous queries is the MediaLib
instance.

When the database queries are executed asynchronously, we must still be
able to delete a list model from the main thread without blocking. As a
consequence, the data loader must be able to outlive the list model
instance; this implies that loading data must not involve calling
methods on the list model itself (fetch() and countTotalElements()).

Nevertheless, the actual data to load depends on the list model (the
content is not the same between a list of videos and a list of albums).

To be able to detach the lifetime of the data loader from the one of the
list model, make the list models provide loader instances on demand,
instead of implementing the loading methods directly.

Currently, the loader is owned by MLModelCache, but in the future it
might outlive it: database queries will be executed from a separate
thread, and MLModelCache could be deleted while an asynchronous request
is running.

To prepare for this change, do not require to receive the loader via a
std::unique_ptr (let the cache wrap it).

Use the new list cache. For now, the cache loader just delegates calls
to the model.

Add a separate class to provide local data caching, independant of the
MLBaseModel implementation.

It will be used in further commits.

MLSlidingWindowModel declares two pure virtual methods to be implemented
by subclasses:
 - countTotalElements()
 - fetch()

The query parameters to use were implicitly defined by the class fields.

Instead, pass them explicitly. This paves the way to implement a
separate cache and execute queries from a separate thread.

The count is initialized by a call to rowCount(), which must be called
before calling item().

The fetch() methods returns the data it loads, it does not need access
(except possibly to mutable fields for caching).

This makes it consistent with countTotalElements().

mishandled in lookups. should be enforced in parsing.
refs VLCKit/-/issues/382

Instead of allocating an empty array for nothing

invalid deref from -1 promotion
0e9db4f7

sout_instance_ControlsPace is not built nor provided by missing.c when
building with --disable-sout

Alaric Senat authored Nov 18, 2020 and Thomas Guillem committed Nov 25, 2020

As pointed out in #25055 the choice of url option delimiter is probably
meant to be that way. std::string.find() returns std::string::npos (aka
-1) in case of no match.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

For now we don't list other devices

After a mute it seems we need to tell report the new volume otherwise it
assumes it's 0.

We keep the gain so we can compute the proper volume to report on mute.

The requested device is set to the default one in Open and requires the MTA
setup in order for the activation to work. Otherwise it deadlocks.

It must be free'd with CoTaskMemFree and only once.

The aout_dev_t type doesn't need to be shared anymore.

Prince Gupta authored Nov 18, 2020 and Pierre Lamot committed Nov 23, 2020

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored Nov 18, 2020 and Pierre Lamot committed Nov 23, 2020

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Prince Gupta authored Nov 18, 2020 and Pierre Lamot committed Nov 23, 2020

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored Nov 20, 2020 and Pierre Lamot committed Nov 23, 2020

this fixes the animation issue that occurs when Qt 5.15 is used

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored Nov 20, 2020 and Pierre Lamot committed Nov 23, 2020

set '_colors' property when forcing colors

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored Nov 20, 2020 and Pierre Lamot committed Nov 23, 2020

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored Nov 20, 2020 and Pierre Lamot committed Nov 23, 2020

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored Nov 20, 2020 and Pierre Lamot committed Nov 23, 2020

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored Nov 20, 2020 and Pierre Lamot committed Nov 23, 2020

due to an incident, a preliminary and incomplete version of "enable aligned player controlbar customization" patch was merged. this update ensures that the latest and the most tested version of the patch is available.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

The has_deint value can never be true at this point.

This code is even dead in 3.0 as DeinterlaceCallback was not called in the init
either.

It's not used by anyone and doesn't match the string of the same core variable.