This fixes a compilation error when partial availability checks
are enforced, as kSecAttrAccessible was not present before
Mavericks. The code already handles it properly, this just disables
the error.

CID #1372939

If an error occurs leading up to the affected paths, the error-message
has to be freed in order to not leak allocated resources.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

There is no need to check for the inverse of a condition that was just
being checked.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

As we do not care which of the calls to dbus_message_iter_append_basic
fails, there is no need for an explicit if for every function
invocation; instead we can rely on the fact that if-conditions
short-circuit.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Previously the function would fail to release acquired resources upon
failure, these changes make sure that we do not leak allocated memory
when this happens.

fixes #17442
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Forgot to add this mutex back during a refactoring.

Instead of calling dbus_connection_send_with_reply_and_block, we do:

 - Setup watch functions in order to get fds and poll events when a callback is
   triggered.

 - Call dbus_connection_send_with_reply() (that won't do anything because no
   mainloop). This will trigger watch callbacks.

 - In loop: call vlc_poll_i11e() with fds fetched from the watch callbacks.
   Call dbus_watch_handle() on the polled fds. This will do the I/O (non
   blocking).

 - Wait for reply from the pending call.

Fix #16409
Modified-by: Thomas Guillem <thomas@gllm.fr>
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Additionally, remove the unlock call as fclose() will drop
the lock for us.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

This works only on Android M, the used cipher is AES/CBC/PKCS7Padding, the IV
(Initialisation Vector) is generated by Android, and the key is stored by
Android.

This module store credentials and crypted secrets on a file.
The internal crypt API needs to be implemented.

This module is deactivated by default.

No functional changes, this just move code in preparation for the next commit.

No functional changes.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Qt moc files should always be marked as nodist_
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Deactivated by default since secret is not encrypted.

To use it (for test purpose only):
./vlc --keystore=plaintext --keystore-plaintext-file=<my_file> <url>