1. 11 Nov, 2017 1 commit
  2. 14 May, 2017 1 commit
  3. 19 Nov, 2016 3 commits
    • Rémi Denis-Courmont's avatar
      playlist: remove position parameter to playlist_Add* · b459e18d
      Rémi Denis-Courmont authored
      This removes the insertion offset parameter to playlist_Add(),
      playlist_AddExt() and playlist_AddInput().
      
      intf_InsertItem() was the only occurrence where the offset was zero,
      a side effect of how the command line is parsed backward. This is now
      done explicitly with playlist_NodeAddInput().
      
      A non-zero positive offset made no sense, since:
       - the number of children of a node can change asynchronously while the
         playlist lock,
       - the back-end asserted or triggered undefined behaviour if the offset
         was out of range.
      DBus was the only occurrence of this bug (see also #17451 comment:4),
      and has been fixed in an earlier change.
      
      In all remaining call sites, the offset was PLAYLIST_END. This removes
      the parameter which would otherwise constitute a useless constant.
      b459e18d
    • Rémi Denis-Courmont's avatar
    • Rémi Denis-Courmont's avatar
      playlist: remove APPEND and INSERT flags · 4a2f6a81
      Rémi Denis-Courmont authored
      They are set but never used. In practice, the (following) position
      parameter determines whether the item is inserted or appended. A
      positive position means insertion; PLAYLIST_END means appendment.
      4a2f6a81
  4. 16 Nov, 2016 1 commit
  5. 21 Mar, 2015 1 commit
  6. 15 Aug, 2014 1 commit
  7. 12 Mar, 2014 1 commit
  8. 07 Jan, 2014 1 commit