1. 17 Jan, 2018 1 commit
  2. 29 Nov, 2017 2 commits
  3. 20 Nov, 2017 1 commit
  4. 11 Nov, 2017 1 commit
    • Romain Vimont's avatar
      gui/qt: bookmarks: fix psz_name lifetime · ea0a32e1
      Romain Vimont authored
      The macro qtu() is defined as follows:
      
          #define qtu( i ) ((i).toUtf8().constData())
      
      "i" is a QString, .toUtf8() returns a QByteArray, .constData() returns a
      pointer to the data inside the QByteArray.
      
      It is important to notice that the QByteArray is temporary. Therefore,
      it is "destroyed as the last step in evaluating the full-expression that
      (lexically) contains the point where [it was] created".
      
      Concretely, this means that this call is correct:
      
          do_something( qtu( string ) );
      
      But this one is undefined behavior:
      
          const char *s = qtu( string );
          do_something( s );
      
      Thus, here, bookmark.psz_name was initialized with a pointer to garbage
      data.
      
      To fix the problem, store the QByteArray in a local variable so that it
      lives long enough.
      
      (Fixes invalid reads reported by valgrind)
      Signed-off-by: Romain Vimont's avatarRomain Vimont <rom@rom1v.com>
      Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <jb@videolan.org>
      ea0a32e1
  5. 30 Oct, 2017 1 commit
  6. 20 Oct, 2017 1 commit
  7. 14 Oct, 2017 4 commits
  8. 21 Sep, 2017 1 commit
  9. 15 Sep, 2017 1 commit
  10. 06 Sep, 2017 1 commit
  11. 05 Sep, 2017 1 commit
  12. 04 Sep, 2017 1 commit
  13. 22 Aug, 2017 2 commits
  14. 08 Aug, 2017 1 commit
  15. 23 Jul, 2017 4 commits
  16. 04 Jul, 2017 2 commits
  17. 31 May, 2017 1 commit
  18. 21 May, 2017 1 commit
  19. 18 May, 2017 1 commit
  20. 16 May, 2017 1 commit
  21. 14 May, 2017 1 commit
    • Rémi Denis-Courmont's avatar
      playlist: allocate the root item statically · 9c77c044
      Rémi Denis-Courmont authored
      This allocates space for the root playlist item directly inside the
      playlist structure. Creation of that item required a special case
      anyway as it was the only item without a parent.
      
      As a consequence, one unhandled error case is removed.
      9c77c044
  22. 25 Apr, 2017 1 commit
  23. 09 Apr, 2017 2 commits
  24. 20 Mar, 2017 2 commits
  25. 15 Mar, 2017 1 commit
  26. 05 Mar, 2017 1 commit
  27. 19 Feb, 2017 1 commit
  28. 24 Jan, 2017 1 commit
  29. 19 Jan, 2017 1 commit