1. 12 Nov, 2017 1 commit
  2. 21 Jun, 2017 2 commits
  3. 26 May, 2017 1 commit
    • Rémi Denis-Courmont's avatar
      vlc_stream_ReadLine: fix trimming 8-bits lines (fixes #18364) · 27849047
      Rémi Denis-Courmont authored
      The conversion from UTF-16 to UTF-8 could (until a few days ago) fail
      before the end. In that case, the appended nul terminator would not be
      converted. A nul terminator is anyway always appended after conversion
      and trimming.
      
      If conversion failed on the first character, that nul terminator would
      be written at a negative offset, leading to heap buffer "underflow" and
      memory corruption. This was fixed but lead to a mismatch in the value of
      i_lines depending on the character width.
      
      This change removes the useless pre-conversion nul terminator, and thus
      makes trimming work again with single byte character width work. This
      fixes reading text files formatted with MS-DOS line endings.
      27849047
  4. 24 May, 2017 3 commits
  5. 16 May, 2017 1 commit
  6. 07 Feb, 2017 1 commit
  7. 06 Dec, 2016 1 commit
    • Filip Roséen's avatar
      stream: rename vlc_stream_NewMRL to vlc_stream_NewURL · e4fbdceb
      Filip Roséen authored
      The function does not open MRLs, as correctly described in its
      documentation, as such it is rather unfortunate that its name uses MRL
      instead of URL (especially given that it cannot handle MRLs).
      
      These changes are simply renaming all occurrences of the function, so
      that the behavior of the function is properly reflected by its name.
      Signed-off-by: Thomas Guillem's avatarThomas Guillem <thomas@gllm.fr>
      e4fbdceb
  8. 31 Oct, 2016 1 commit
    • Rémi Denis-Courmont's avatar
      stream: assert that read size is well defined · 3bf8a8ec
      Rémi Denis-Courmont authored
      The result of a read operation is a signed size_t, and cannot be
      negative (except on error). Thus reading more than SSIZE_MAX bytes at
      once is not well defined.
      
      (Note: POSIX marks it as implementation-defined, and we cannot rely on
       much given the different implementations.)
      
      In practice, this is not really a limitation for regular reads as
      allocating a contiguous output buffer of more than SSIZE_MAX bytes is
      essentially impossible. It can however be a problem when skipping data
      (buffer pointer is NULL), especially on 32-bits platforms.
      
      To skip such large amount of data, seeking is recommended instead,
      e.g.:
      
          vlc_stream_Seek(s, vlc_stream_Tell() + skip);
      
      instead of:
      
          vlc_stream_Read(s, NULL, skip);
      3bf8a8ec
  9. 25 Jul, 2016 1 commit
  10. 24 Jul, 2016 1 commit
  11. 21 Jul, 2016 9 commits
  12. 20 Jul, 2016 1 commit
  13. 05 Jun, 2016 1 commit
  14. 19 May, 2016 1 commit
    • Thomas Guillem's avatar
      access: re-refactor pf_readdir · 9109718b
      Thomas Guillem authored
      This commit changes pf_readdir callback to its original behavior. Accesses and
      streams now add items to a node.
      
      Archive stream_filters will now be able to add nodes to a node (when an archive
      has directory). This was not possible before.
      
      This commit also adds an access_fsdir helper to help fs accesses (file, smb,
      nfs, ftp, sftp) adding items to a node. These accesses need the same treatment
      that is now done by this helper:
       - hide hidden files or not (depending on "show-hiddenfiles" option)
       - skip some file extensions (depending on "ignore-filetypes" option)
       - sort items by type and alphabetically (depending on "directory-sort"
         option).
       - For a next commit: attach slaves to items
      
      The directory demux won't do these operations anymore for every access/stream.
      
      This commit doesn't change the interruptible state of the pf_readdir function,
      accesses/streams are still interruptible in the middle of a pf_readdir call.
      
      This partially reverts commit 88ffe158.
      9109718b
  15. 02 Apr, 2016 1 commit
  16. 05 Oct, 2015 1 commit
  17. 03 Sep, 2015 2 commits
  18. 02 Sep, 2015 5 commits
  19. 01 Sep, 2015 3 commits
  20. 31 Aug, 2015 3 commits