1. 12 Nov, 2017 1 commit
  2. 11 Nov, 2017 1 commit
  3. 04 Oct, 2017 2 commits
  4. 21 Sep, 2017 1 commit
  5. 20 Sep, 2017 1 commit
  6. 19 Sep, 2017 1 commit
  7. 04 Sep, 2017 2 commits
    • Hugo Beauzée-Luyssen's avatar
      Revert "input: De-duplicate titles" · 070cd462
      Hugo Beauzée-Luyssen authored
      This reverts commit 66401825.
      
      This triggers a race between the interface and the input thread.
      The playlist signals that a new input_thread_t is now the current item,
      while the input thread tries to create the input_source_t containing the
      titles.
      If the interface reacts to the new item and tries to refresh the titles
      before the input_source_t has been assigned to
      input_thread_private_t::master, a crash will occur.
      IMHO, having the titles duplicated is best for now, considering that
      there will be massive changes to the playlist in 4.0
      070cd462
    • Hugo Beauzée-Luyssen's avatar
      input: De-duplicate titles · 66401825
      Hugo Beauzée-Luyssen authored
      Store them in the input source
      66401825
  8. 25 Jul, 2017 1 commit
    • Thomas Guillem's avatar
      input: add INPUT_SET_INITIAL_VIEWPOINT control · 3fdd4286
      Thomas Guillem authored
      This new control sets an initial viewpoint (generally comming from the video
      ES) to the input.
      
      If the viewpoint had already been changed by the user, the input viewpoint
      value won't change and the user viewpoint will be sent to all ESes.
      3fdd4286
  9. 10 Jun, 2017 1 commit
  10. 19 May, 2017 1 commit
    • Filip Roséen's avatar
      input/control: INPUT_CHANGE_BOOKMARK: fix leak and return · db9941a7
      Filip Roséen authored
      The previous implementation would potentially try to duplicate a
      seekpoint that was never used due to invalid arguments, as well as
      leaking said duplicate.
      
      These changes make sure that we do not leak the resource, while also
      preventing the unnecessary duplication + returning an error if
      we are unable to complete the operation.
      
      CID: 1409711
      Signed-off-by: Thomas Guillem's avatarThomas Guillem <thomas@gllm.fr>
      db9941a7
  11. 18 May, 2017 6 commits
  12. 17 May, 2017 2 commits
  13. 06 Mar, 2017 1 commit
    • Filip Roséen's avatar
      input/control: INPUT_GET_SEEKPOINTS: prevent out-of-bounds reads · 8a0272b8
      Filip Roséen authored
      The previous implementation would potentially read the "element" right
      after the last one in the subsequently used array (as priv->i_title
      denotes the number of titles present).
      
      These changes also include a check to make sure that var_GetInteger(
      p_input, "title" ) does not result in a negative value (as such can be
      used to read from outside the array, but on the other side).
      Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <jb@videolan.org>
      8a0272b8
  14. 03 Mar, 2017 1 commit
    • Filip Roséen's avatar
      input/control: remove unnecessar memory allocation · 9f4b1a47
      Filip Roséen authored
      Hi `vlc-devel`,
      
      On 2017-03-01 09:52, Filip Roséen wrote:
      
      > diff --git a/src/input/control.c b/src/input/control.c
      > index f4781eb1a5..ff6df4c2fe 100644
      > --- a/src/input/control.c
      > +++ b/src/input/control.c
      > @@ -399,7 +399,7 @@ int input_vaControl( input_thread_t *p_input, int i_query, va_list args )
      >                  return VLC_EGENERIC;
      >              }
      >
      > -            input_title_t *p_title = vlc_input_title_Duplicate( priv->title[*pi_title_to_fetch] );
      > +            input_title_t *p_title = priv->title[*pi_title_to_fetch];
      
      I just noticed that this patch results in a warning due to
      `input_thread_private_t::title` being *const-qualified*, and `p_title`
      lacking such qualifier.
      
      See attached patch for a fixup of [`d1feba6e`][1].
      
      Best Regards,\
      Filip
      
      [1]: http://git.videolan.org/?p=vlc.git;a=commit;h=d1feba6e5f90e48e41cc507ab574f3a1091047f5
      
      >From dc5e79e1c83075522e1ef21318ea807a3946d5f9 Mon Sep 17 00:00:00 2001
      From: =?UTF-8?q?Filip=20Ros=C3=A9en?= <filip@atch.se>
      Date: Thu, 2 Mar 2017 16:39:38 +0100
      Subject: [PATCH] input/control: INPUT_GET_SEEKPOINTS: apply const to silence
       warning
      
      priv->title[n] results in a pointer-to-const, which means that the
      initialization of p_title discards the const qualifier; this addition
      fixes that warning while also making the implementation more correct.
      Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <jb@videolan.org>
      9f4b1a47
  15. 01 Mar, 2017 1 commit
  16. 15 Nov, 2016 1 commit
  17. 05 Nov, 2016 2 commits
  18. 07 Jun, 2016 1 commit
  19. 31 May, 2016 1 commit
  20. 13 May, 2016 1 commit
  21. 21 Nov, 2015 1 commit
  22. 24 Oct, 2015 1 commit
  23. 04 Sep, 2015 1 commit
  24. 17 Jun, 2015 1 commit
  25. 16 Jun, 2015 1 commit
  26. 09 Jun, 2015 2 commits
  27. 22 May, 2015 2 commits
  28. 06 Jan, 2015 1 commit
  29. 14 Sep, 2014 1 commit