The snapshot picture was created using picture_Copy(), which does not
handle offsets. As a consequence, snapshots of cropped videos were
broken.

Use picture_Clone() (shallow copy) instead, then copy the crop settings
from the format.

Fixes #18970
Signed-off-by: Romain Vimont <rom@rom1v.com>
Acked-by: Thomas Guillem <thomas@gllm.fr>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

 - don't match 2 possible slaves between each others
 - The slave name len should not be twice longer than the item name len.
   (avoid matching "2016 - blabla.aac" with "20.mkv" for example)

The matching algorithm is still quite dumb and far from perfect. We should
detect item as slaves only if they have a language indication in their path
name.

Fixes #18913

This reverts commit 3767a33c.

This ensures that the dead event input is not missed. The condition
variable was not used properly.

Any started input will eventually emit the dead event if/when it ends.
There are no needs to track the state event separately.

Nowadays, multiple pictures might share the same buffers. Consequently
the reference count of a single picture may be one even though there
are other references to the same buffers through a different picture.

Luckily picture_IsReferenced() is only really used in one place in
stream output, and then it was only an optimization.

This reverts commit 34860e84.
Opening the keystore might trigger a user action while this is meant to
be a silent operation, especially if the service we're connecting to
doesn't require credentials

This was preventing known credentials to be used on first connection,
causing 2 connection attempts where 1 would have been enough

This could cause a high priority subtitle to be not displayed if a previous low
priority subtitle was added.

If no sub track has already been selected via sub-file or autodetection.

Close #18897
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

This also fixes "Small G with Cedilla" on both 6937 and 6937-2.

Fixes #18361
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

triggers incorrect sar / subpicture size when
sar is set (scaling down)

See LocalCacheFolder
https://docs.microsoft.com/en-us/uwp/api/windows.storage.applicationdata#Windows_Storage_ApplicationData_LocalCacheFolder

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Used to force extractors to flatten their file listing (done automatically by
vlc_readdir_helper helper).