Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

This was not noticed since none of the call sites check for error.

Within all the introduced static libraries, the module cannot be known
at compilation time. This moves the module name from a compilation
constant to a link time constant string symbol. That way, the same
compiled object within a static library can use a different and correct
module name depending on which plugin it is linked into.

The symbol is hidden so it does not leak between shared objects. For
non-plugins shared libraries (vlccore, vlc, vlc_pulse and
vlc_xcb_events) the module name must be defined manually, unless the
library does not use msg_* macros at all (vlc_vdpau).

Fuzzers don´t like large allocations. And in fact, real systems don´t
really like them either.

Modified-by: Thomas Guillem <thomas@gllm.fr>:
Changed the value from (size >> 24) to (size >> 27) (from 16 MB to 128MB).
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

It could happen when i_extra was 0 but p_extra was not NULL (since malloc(0)
can return a valid pointer).

One byte is (potentially) needed to append the final nul.

In order to avoid confusion with future vlc_alloc.

Yes, Windows does it the wrong way... What can we do?

Close #19025
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This is the same logic as the TLS code now.

The snapshot picture was created using picture_Copy(), which does not
handle offsets. As a consequence, snapshots of cropped videos were
broken.

Use picture_Clone() (shallow copy) instead, then copy the crop settings
from the format.

Fixes #18970
Signed-off-by: Romain Vimont <rom@rom1v.com>
Acked-by: Thomas Guillem <thomas@gllm.fr>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

 - don't match 2 possible slaves between each others
 - The slave name len should not be twice longer than the item name len.
   (avoid matching "2016 - blabla.aac" with "20.mkv" for example)

The matching algorithm is still quite dumb and far from perfect. We should
detect item as slaves only if they have a language indication in their path
name.

Fixes #18913

This reverts commit 3767a33c.

This ensures that the dead event input is not missed. The condition
variable was not used properly.

Any started input will eventually emit the dead event if/when it ends.
There are no needs to track the state event separately.

Nowadays, multiple pictures might share the same buffers. Consequently
the reference count of a single picture may be one even though there
are other references to the same buffers through a different picture.

Luckily picture_IsReferenced() is only really used in one place in
stream output, and then it was only an optimization.