Commit 5e79a6bd authored by Marvin Scholz's avatar Marvin Scholz

macosx: Do not release VLCDialogWindow instance

Releasing it at this point causes a crash later.
Given that we do a CFBridgingRetain, not releasing it here possibly
reintroduces a memory leak, and should be investigated at some point.

Fix #19772
CD f26743f6-af62-451f-99d1-02a3e02b98a7

(cherry picked from commit c657a089)
Signed-off-by: Marvin Scholz's avatarMarvin Scholz <epirat07@gmail.com>
parent 4c5a74de
......@@ -468,7 +468,10 @@ static void extensionDialogCallback(extension_dialog_t *p_ext_dialog,
{
assert(p_dialog);
VLCDialogWindow *dialogWindow = CFBridgingRelease(p_dialog->p_sys_intf);
/* FIXME: Creating the dialog, we CFBridgingRetain p_sys_intf but we can't
* just CFBridgingRelease it here, as that causes a crash.
*/
VLCDialogWindow *dialogWindow = (__bridge VLCDialogWindow*)p_dialog->p_sys_intf;
if (!dialogWindow) {
msg_Warn(getIntf(), "dialog window not found");
return VLC_EGENERIC;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment