GitLab

Fixes asserts in directory module.

We need to rework modules/playlist and implement refcounting or proper id management.

playlist: playlist_DeleteInputInParent->playlist_DeleteFromInputInParent to match playlist_DeleteFromInput.

playlist: Use PL_LOCK_IF and PL_UNLOCK_IF to perform some more checks on lock state. And fix a unlocked usage of get_current_status_item().

That may fix or help to fix some input item leaks.

playlist: Don't export playlist_ItemNewFromInput as it is not used, and don't use pl_Yield from here.

This could trigger some interface bugs, especially if they handle their callbacks carelessly. Revert if you have issues, but also consider to fix your interface.

Note that the only aim of this array seems to be counting the non-node items

This improves readability a lot and prevent us from reinventing the wheel.

Do not use playlist_*AddInput() when the playlist has already been destroyed and is dying (fix a crash when exiting while directory access is still reading) Try to return early if one of those function fail, because it either mean we don't have anymore memory available (I'm still looking for infinite Turing machines), or we are exiting (the playlist is dying). Use object / thread helpers for simplicity

Missing some cases that I could not test.
Also ffmpeg/chroma.c is locked, so I can but leave it broken.
Fix is for the remaining modules is obvious and the issue is easy to detect.

You can not change a playlist_item_t to be a node, when you previously registered events on it, using input_item_t sub items adding event, because the pointer will be destroyed.
If you want to use nodes anyway, you have to explicitely create them.
Note: we were lucky that xspf did work so far, because we were EXCLUSIVELY using invalid pointers, except for the 1st item being added to each playlist_item_t (it did happen before the conversion obviously).

playlist_Clear() should delete only the local playlist, not the root playlist (including the media library, and the read only services discovery)

playlist/items.c: Add a left over that might prevent art/meta from being fetched. Reported by ileoo.

Enforce access to input_item_t through input_item_{G,S}et*()
Unlock mutexes before calling these functions
Free strings returned by input_item_Get*()

New functions added:

char * input_item_GetURI( input_item_t  * )
void input_item_SetURI( input_item_t * , char * )

mtime_t input_item_GetDuration( input_item_t * )
void input_item_SetDuration( input_item_t * , mtime_t )

to access input_item_t->psz_uri and input_item_t->i_duration