GitLab

Given that the path handles both "region" and "style" attributes,
unconditionally having warnings that includes usage of "Style" is
rather misleading.

These changes fixes the issue by chaning the warning-diagnostic to
include more relevant information.
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

The previous implementation assumed that an attribute would always
have at least one specified region/style, which is not always the
case.

An attribute's value of zero-length, or one that contains only spaces,
would make strtok_r return NULL - resulting in undefined-behavior
further down the road.

In order to prevent these issues, an additional branch has been
introduced to warn if such attributes are found, and simply ignore
them.

fixes #17405
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

fixes #17403
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Fix cid #1346962

fix cid #1372941

fix cid #1372943

fix cid #1372964

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

The functions which use the styles will merge their
attributes, and to avoid consequences of these merges on the
original styles, we work with duplicates.
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

To simplify how the function works, we first parse and merge
all the tag attributes and push the resulting style onto the
style stack, and when we find text, we create the text segment
and apply the last style on it
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

ParseTTMLStyle is now able to parse any type of tag according
to its name and to create a style according to its attributes
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Fix CID #1346962

Signed-off-by: Boris Egorov <egorov@linux.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This reverts commit 48a867c7.

Revert for futher checking

If blocks are marked BLOCK_FLAG_DISCONTINUITY then do not drop them,
unless BLOCK_FLAGS_CORRUPTED is set. Instead flush old blocks from decoder
queue and restart at this new stream access point (new timeline).
Signed-off-by: Ilkka Ollakka <ileoo@videolan.org>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

The current workflow is often parsing a subtitle format, then convert it
in a common HTML and then push it to the renderer as HTML. The renderer
will reparse the HTML and try to render it. Of course, that means that
only one renderer can do that correctly, and so we bloat the freetype
renderer as much as we can.
It also means that we have 2 render callbacks for subtitles, one for
normal text and one for styled text, and we sometimes reparse the HTML
to remove the tags, for the first.

We now only use a text_segment, with new segments at every style change;
an unique render function and the renderer can decide to honor or not
the style.

It's a big commit, so regressions can arise, but it was tested for most
common cases.

This is meant to serve as a base for our Outreachy student's project:
https://wiki.gnome.org/Outreachy/2015/MayAugust#VideoLAN
refs #9396