1. 08 Jun, 2010 2 commits
  2. 24 May, 2010 1 commit
  3. 23 Feb, 2010 1 commit
  4. 13 Feb, 2010 3 commits
  5. 09 Feb, 2010 2 commits
  6. 07 Feb, 2010 1 commit
  7. 05 Feb, 2010 1 commit
  8. 28 Jan, 2010 1 commit
  9. 06 Jan, 2010 1 commit
  10. 05 Jan, 2010 1 commit
    • Erwan Tulou's avatar
      core: correct memory leak · 460ab654
      Erwan Tulou authored
      var_Change with VLC_VAR_SETVALUE showed a memory leak when dealing with a STRING variable.
      The pf_dup function must not be called directy with a parameter passed by the caller.
      otherwise, a reference is lost (memory leak)
      Signed-off-by: default avatarRémi Duraffort <ivoire@videolan.org>
      460ab654
  11. 03 Jan, 2010 5 commits
  12. 30 Dec, 2009 7 commits
  13. 29 Dec, 2009 5 commits
    • Rémi Denis-Courmont's avatar
      69258670
    • Rémi Denis-Courmont's avatar
      bca54820
    • Rémi Denis-Courmont's avatar
      Allocate variable and inherit value before the variables lock · 8b045d0d
      Rémi Denis-Courmont authored
      The initial value of the variable must be correct when the variables
      lock is released after the variable was created. Hence we could not
      release the lock between Insert() and InheritValue(). If we did, there
      would be a race where another thread could see the variable with the
      generic default value (0, "", 0., ...) instead of the inherited value.
      
      So instead, we inherit the value in a temporary variable on the stack,
      before we take the variables lock. Then we can create the variable with
      the correct value without taking the lock for the duration of
      InheritValue().
      
      This adds overhead when an existing variable is re-created (i.e.
      reference count is increased but no new variable is created). But it
      dramatically reduces contention on the variables lock. More importantly,
      it allows calling InheritValue() without the variables lock. So when we
      fix InheritValue(), which is currently not thread-safe, we won't have
      any problem with nested locking.
      8b045d0d
    • Rémi Denis-Courmont's avatar
      Remove buggy and never used VLC_VAR_INHERITVALUE · c85d6074
      Rémi Denis-Courmont authored
      InheritValue() is not thread-safe. It runs under the variable lock of
      the object creating the new variabe. But it reads variables of parent
      objects. This would require the variable lock of the parent object.
      
      We still need to fix var_Create() with VLC_VAR_DOINHERIT.
      c85d6074
    • Rémi Denis-Courmont's avatar
      c1f4a7df
  14. 06 Dec, 2009 1 commit
  15. 05 Dec, 2009 1 commit
  16. 16 Sep, 2009 1 commit
    • Pierre Ynard's avatar
      Fix parsing of float-typed variables · 48a3ced7
      Pierre Ynard authored
      Apparently, since 'setlocale( LC_NUMERIC, "C" );' was removed from
      libvlc initialization 3 years ago, the syntax to set configuration
      variables of floating point types has changed and become dependent
      on the current locale ("0.5" vs. "0,5" etc). Some places have been
      converted to the use of us_atof() which is locale-independent; fix
      all the remaining ones too.
      48a3ced7
  17. 14 Sep, 2009 1 commit
  18. 31 Aug, 2009 1 commit
  19. 30 Aug, 2009 2 commits
  20. 27 Aug, 2009 1 commit
  21. 03 Aug, 2009 1 commit