GitLab

Backported from 0.9-bugfix

1/ pgp v4 signature checks of status files with more than 506 bytes would fail
2/ pgp v4 signature checks would fail (code dupication sucks).

This code is quite a mess. We shouldn't need to implement all this lowlevel stuff. I'll remove most of it and use pgpme instead.

For the time being, this means that upcomming releases should use v3 signatures for the downloaded files and shouldn't use status files of more than 506 bytes (or maybe shouldn't use v4 signatures for status files either)

As discussed on IRC. Yield was quite confusing.

Avoid objects being detached asynchronously too early.
Side effect is that you cannot free your children in the destructor
(that would be a reference loop).

This re-implements [45e43037], but this time it compiles AND runs.

This fixes [45e63d59]

Deadlocks libvlc, and atm. I do not know how to fix this.
This reverts commit 45e43037.

Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>

This should fix a memleak with variable strings, and several other problems. Note that a CLASS detemines the basic type, and that TYPE is only a specific set within the CLASS. The variable types: VLC_VAR_KEY and VLC_VAR_INTEGER are both of CLASS integer. and thus compatible, when it comes to inheritence/init/free etc.

It will allow detecting stupid typos.

It merely wrappeded the SAP object.

I (and dionoea too, I think) encountered an "assertion failed self ==
0" when trying to play a file on win32. I think the following patch
solves this issue. If I understand correcly, the intended behaviour
was to zero the owner field of the mutex when releasing it.

Modified by Courmisch to use InterlockedExchange() directly.
Signed-off-by: Rémi Denis-Courmont <rdenis@simphalempin.com>