GitLab

There is no potentially cancellation-unsafe code here (unlike Qt4),
since msg_Free() is safe and vlc_mutex_*() of course too.

Also move some stuff from vlc_config.h to vlc_aout*.h

Also protect concurrent access to p_sys between main thread and libvlc callbacks

fixes: #4827

Fix #4797

 - remove always zero overruns counter,
 - constify message pointer.

Message items are more often than not not rereferenced, and hardly ever
rereferenced more than once. Demand-copying will be faster in most
common circumstances (especially built-in console or logger).

Only two call sites checked for errors. Anyway, the implementation does
not check for errors.

This fixes opening of file names containing non-ASCII characters

redraw happens on getch() return, on timeout (1 second), or on keypress
wether the key was handled or not.

input change is now checked in the main loop

add a comment at the intention of the translators to tell them they can
use fancy Unicode characters
since this comment is UTF-8, add --from-code=UTF-8 option to xgettext

Use a macro to make DrawHelp() lines shorter
Merge 'Boxes' with 'Global' help category

Use a ncurses timeout() of 1 second, which will block when waiting for input

We use 1 second so the position slider is refreshed correctly
We could use 500ms to not miss any change, now the slider can make a
2 seconds jump, see Nyquist-Shannon theorem

Add a variable to the context to exit the main loop as soon as the exit key
is pressed, so we don't have to wait one more second: vlc_object_alive()
doesn't return false immediately after calling libvlc_Quit()

- use libvlc verbosity
- reset default color after having displayed the messages

flat/tree view seems to be controlled by playlist-tree option these days

- remove some messages logging dead code
- don't store the ncurses WINDOW, use global stdscr instead
- add some fancy unicode characters to the help
- factorize list navigation key handling
    all boxes now use the same code than PLAYLIST/BROWSE
    this means there is now a selector in every box
- break Redraw() in several functions
- remove fancy characters from Status box drawing code
    use the same layout than meta-info / info boxes
- fix a display bug in objects box
- simplify some functions and remove unneeded arguments
- avoid a strdup() in ReadDir() loop

        Known regressions:
- when switching back to PLAYLIST box, the selector will be set to the
  playing item only after the 2nd refresh (i.e. maximum 1 second later)

Also assume p_item->i_es is set correctly

- use switch/case instead of if/else if/else if
- factor out HandleEditBoxKey() and HandleCommonKey()
- return bool instead of int

Use one line per switch label when it improves readability
Also explicit the sign of position increment even when positive so +x and -x are aligned