1. 17 May, 2017 3 commits
  2. 16 May, 2017 3 commits
  3. 15 May, 2017 2 commits
  4. 28 Apr, 2017 1 commit
  5. 22 Apr, 2017 1 commit
  6. 18 Apr, 2017 2 commits
  7. 13 Apr, 2017 2 commits
  8. 09 Apr, 2017 2 commits
  9. 07 Apr, 2017 2 commits
  10. 06 Apr, 2017 2 commits
  11. 28 Mar, 2017 3 commits
  12. 22 Mar, 2017 2 commits
  13. 21 Mar, 2017 1 commit
  14. 20 Mar, 2017 1 commit
  15. 16 Mar, 2017 1 commit
  16. 15 Mar, 2017 1 commit
  17. 10 Mar, 2017 1 commit
  18. 06 Mar, 2017 1 commit
    • Filip Roséen's avatar
      input/control: INPUT_GET_SEEKPOINTS: prevent out-of-bounds reads · 8a0272b8
      Filip Roséen authored
      
      
      The previous implementation would potentially read the "element" right
      after the last one in the subsequently used array (as priv->i_title
      denotes the number of titles present).
      
      These changes also include a check to make sure that var_GetInteger(
      p_input, "title" ) does not result in a negative value (as such can be
      used to read from outside the array, but on the other side).
      Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <jb@videolan.org>
      8a0272b8
  19. 05 Mar, 2017 1 commit
  20. 03 Mar, 2017 1 commit
    • Filip Roséen's avatar
      input/control: remove unnecessar memory allocation · 9f4b1a47
      Filip Roséen authored
      Hi `vlc-devel`,
      
      On 2017-03-01 09:52, Filip Roséen wrote:
      
      > diff --git a/src/input/control.c b/src/input/control.c
      > index f4781eb1a5..ff6df4c2fe 100644
      > --- a/src/input/control.c
      > +++ b/src/input/control.c
      > @@ -399,7 +399,7 @@ int input_vaControl( input_thread_t *p_input, int i_query, va_list args )
      >                  return VLC_EGENERIC;
      >              }
      >
      > -            input_title_t *p_title = vlc_input_title_Duplicate( priv->title[*pi_title_to_fetch] );
      > +            input_title_t *p_title = priv->title[*pi_title_to_fetch];
      
      I just noticed that this patch results in a warning due to
      `input_thread_private_t::title` being *const-qualified*, and `p_title`
      lacking such qualifier.
      
      See attached patch for a fixup of [`d1feba6e`][1].
      
      Best Regards,\
      Filip
      
      [1]: http://git.videolan.org/?p=vlc.git;a=commit;h=d1feba6e5f90e48e41cc507ab574f3a1091047f5
      
      
      
      >From dc5e79e1c83075522e1ef21318ea807a3946d5f9 Mon Sep 17 00:00:00 2001
      From: =?UTF-8?q?Filip=20Ros=C3=A9en?= <filip@atch.se>
      Date: Thu, 2 Mar 2017 16:39:38 +0100
      Subject: [PATCH] input/control: INPUT_GET_SEEKPOINTS: apply const to silence
       warning
      
      priv->title[n] results in a pointer-to-const, which means that the
      initialization of p_title discards the const qualifier; this addition
      fixes that warning while also making the implementation more correct.
      Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <jb@videolan.org>
      9f4b1a47
  21. 01 Mar, 2017 1 commit
  22. 26 Feb, 2017 1 commit
  23. 24 Feb, 2017 1 commit
  24. 23 Feb, 2017 2 commits
  25. 21 Feb, 2017 2 commits