GitLab

According to INSTALL, we require GCC 4.8 already.

This fixes the vlc_stream_Read() compiler warning.

As pointed out by Filip, some archs could pad the structure to a
boundary larger than 8 bytes, defeating the sizeof() value.

This fixes insecure use of tempnam(), fixes a potential file leak onto
the filesystem and simplifies the code.

Never worked

This refactor adds more code since it adds a lot more of error checking.

coreaudio_common.c/.h contains the common code for auhal.c and audiounit_ios.m.

TODO: factor StartAnalog.

Also fix a AudioUnit leak in case of error.

we might want to override timestamps, not just
deal with video pts

Given that p_sys->p_obj is yet to be initialized with the value of the
obj, the implementation should use the latter (given that the former
will be zero-initialized, but nothing more).
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Both gcc and clang generate warnings for unsupported -f$FLAG by
default, meaning that the previous implementation would consider
unsupported flags as supported (as a warning is not an error that
fails compilation).

The addition of -Werror treats warnings as errors, and will prevent
false-positives in terms of -f$FLAG support.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>