GitLab

TODO: someone fix it

Also, fix a small leak in vlc_clone() error path.

This patch introduces support for using V4L2 VBI devices for
reading NTSC EIA-608 closed captions.

This patch includes feedback from the vlc-devel mailing list from
the Oct 21, 2012, Oct 28, 2012, and Nov 18, 2012 submission attempts.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Re-license almost all the playback modules to LGPLv2.1+ with
authorization from their respective contributors (230+)

This includes:
 - access, codec, packetizers, demux
 - audio filters, audio mixers, audio output
 - video filters, video chroma, video output
 - text renderers
 - XML parser
 - ARM NEON and SSE2 optimisations (mostly for chromas and filters)

Some modules are not concerned:
 - BDA and DShow access modules because Manol Manolov is AWOL
 - Real RTSP, because it is derived from Xine
 - x264 and t140 because they are encoders only
 - DLL Loader, because it is derived from MPlayer
 - DTS packetizer, because Jon Lech Johansen is AWOL
 - Shine and WMAfixed, because they are derived from Rockbox
 - Real demuxer, as it is derived from MPlayer and Wang Bo is AWOL
 - MPC demuxer, as Yavor Doganov is AWOL
 - Tivo demuxer, because it is derived from an MPlayer fork
 - Playlist demuxer, (WPL and ZPL parts missing), because suheaven is AWOL
 - iOS audio output and video display, because author refuses the license change
 - Equalizer and compressor, because Ronald Wright is AWOL
 - Mono, Headphone and Dolby, because author refuses the license change
 - hqdn3d and yadif, because they are from MPlayer/libavfilter
 - remoteosd, because it derives from RealVNC code
 - MMX optimisations, because Ollie Lho, from SiS, is AWOL
 - Rotate, because it depends on GPL motion

Nota Bene:
 - Some modules depend on GPL-only libraries, a LGPL module does not mean
   that the resulting binary module will be LGPL.
   Libraries affected would include liba52, libdvdcss, libdvdnav, libdvdread,
   faad2, libdca, libmad, libmpeg2, libpostproc, SRC, sid, zvbi and probably others.

As agreed last week with upstream, that's basicailly the least insane
way to deal with the ever changing and expanding V4L2 API. This allows
compiling VLC with old Linux headers and run it well on a new Linux
kernel. This also avoids a pile of backward compatibility hacks.

A few other userspace tool already copy videodev2.h like that.

This will be used by the radio tuner.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Shared anonymous mapping did not make much sense.

This is negotiated automatically. Unfortunately, it will fail in most
cases (gspca might support it, UVC only supports it in future kernel
version 3.4, and libv4l does not support it anyway).

We do not dequeue those events. That could cause busy loops.

(regression from 855f0b7d)

Also fix huge memory leak in v4l2 access (buffers never released).

In case of pure access:
 - use correct access_sys_t type,
 - remove unused parameters.

Especially fix memory leaks on error.

Previously, VLC would assume 4/3 picture aspect ratio. That was quite
lame. This patch makes --v4l2-aspect-ratio redundant.

 * Enumerate frame sizes once rather than twice.
 * Do not enumerate frame rates if not supported.
 * Get actual frame rate from the device driverr.
 * Get exact fractional frame rate rather than round to single precision
   floating point.

Notes:
 * --v4l2-fps becomes totally redumdant. It should probably be redefined
   to select a maximum capture frame rate.
 * --v4l2-width and --v4l2-height are ignored. This is a regression.
   Maybe they should be redefined as maxima as well as --v4l2-fps.

"capabilities" counter-intuitively specifies the overall capabilities of
all device nodes provided by the given instance of the device driver.
"device_caps" specifies the capabilities of the opened device node,
if the V4L2_CAP_DEVICE_CAPS bit is set in "capabilities" (phew!).
Those two sets of capabilities are different if the hardware has
multiple functions, e.g. both video and VBI capture.

VLC cares about the fact that the specific device node supports video
capture or not, so lets use "device_caps" when available. Unfortatunely,
this requires kernel version 3.4. In practice, this would only cause an
actual failure if V4L2_CAP_STREAMING is set even though the current node
does not support streaming I/O, I think.

There is not that much common code left for the access case, except for
debug messages. The resulting code is a lot easier to read IMHO.
Also I have no way to test the access plugin, so lets split it where it
will not get more broken.