GitLab

This improves readability a lot and prevent us from reinventing the wheel.

misc/objects.c: Don't rely on vlc_object_destroy() to destroy objects, but expects vlc_object_release to do it when the refcount goes to zero.
* Meaning, that when created objects gets a refcount to 1.
* Destroying is instantaneous and we don't have to poll for a few secondss or so to wait until the object's refcount reach 0.
* We now track vlc_object_t's mem leaks when libvlc_global is released (Hard error for now, so they don't get unoticed)
* We fail hard if an object is released with a refcount of 1 without being detached from its parent and its children, to make sure such cases don't go unoticed.
(make test or make check still pass after that one. VLC is known to leak one object when no module is loaded, this must be fixed).

Missing some cases that I could not test.
Also ffmpeg/chroma.c is locked, so I can but leave it broken.
Fix is for the remaining modules is obvious and the issue is easy to detect.

Always check the certificates chain - it does not make any sense, is counter-intuitive and insecure to use x509 but not validate certs.
The whole security and point of TLS rely on this...

(this would be a bug in whatever is using the TLS object anyway)

These are not confidential, and fairly slow to compute.
(This is much simpler than caching them to disk, and more
 portable-app-friendly)

This makes TLS server initialization a lot faster (especially under valgrind)

directories as world-writable - fixes #1306

These are are quite slow to compute, so it could be used to speed up start up
once reading them from the cache is also implemented.

Hmm, there is a security problem in this commit (cache file is world-readable).

Remove the singleton pattern. Still very much work in progress.

I wonder why I added this option in the first place.

On OSes other than Windows, Mac OS X and BeOS (so it's Linux) comply with the XDG Base Directory Specification version 0.6. The old configuration file (vlcrc) will be copied to the new location. Other data like caches will have to be rebuilt (the album art cache in VLC was new in 0.9.0 so it's ok to lose it). Closes #1267

Also never destroys global mutex, otherwise we get a race condition
(which is pretty contradictory to the point for mutexes)

(There was no bug here; this is just to please Quovodis :) )

- Do not leak result from utf8_readdir (ALWAYS strdup'ed).

  * utf8_fopen for: galaktos and snapshots
  * vlc_closedir_wrapper for: webintf, mkv, ncurses and gnutls