GitLab

Laurent Aimar authored Aug 12, 2010 and Rémi Denis-Courmont committed Aug 12, 2010

Fixes: #3928
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

split allocation into a separate function to remove one level of indentation
split some overly long statements
factorize some bits

green line is still present at bottom of output

So LibVLC won't try to use a video output that cannot be embedded.

X11 inherits properties from the parent window by default. XVideo does
not (typically) like ARGB visuals. To create plain RGB window on an ARGB
window, we need to force the color map, background and border parameters
to non-ARGB values.

There is one remaining problem to enable ARGB support in Qt4: the Qt4
video widget has a transparent background by default. This is inadequate
in fullscreen mode.

The maximum number of surfaces it will allow is now 128, but the actual value
used is configured by the core (around 20-30 when DR is used, a few otherwise).

This reverts commit ec468212.

Conflicts:

	modules/gui/qt4/qt4.cpp
	modules/video_output/msw/events_vo.c
	modules/video_output/x11/xcommon.c
	modules/video_output/xcb/common.c
	modules/video_output/xcb/window.c
	src/video_output/window.c

This enables passing a below state in addition to currently supported
always-on-top (above) and normal. (However, none of the window provider
support it just yet).

X11 extensions are upward compatible only if they have the same major
version number. In other words, we wouldn't support XVideo >= 3.0.

It is used in many places, namely all X11 plugins _except_ the video
display ones. So it did not make much sense to keep it there IMHO.

This simplifies XCB-X11 a little bit, and speeds up failure cases of
XCB-XV. More importantly, it will enable ARGB rendering for XCB-X11.

This ensures events are delivered when the mouse moves outside the
rendering area but within the embedding drawable. This is necessary to
autonatically unhide the cursor. As a side effect, we need to adjust
the pointer coordinates.

The X server will do as part of garbage collection - as it does for our
window, graphic context, or if VLC crashes.