GitLab

The old VLCIntf macro is deprecated, getIntf() should be used
instead.

This removes the singleton, fixes the xib, and initializes
the dialog provider class at the correct time. dialog_Register
will be called only once now.

macosx: privatise instance variables and resolve class dependencies on internal implementation details

This should fix some crashes as reported by the users.

It does not make sense to open the messages window here anymore, as
it will not show any additional details if not already open.

macosx: dialogs provider: fix crash for question dialog and also improve robustness of other dialogs

This reverts commit 00b2fcce.

[__MNSArray objectAtIndexedSubscript] isn't part of the OS X 10.7 ObjC runtime and in turn, we can't use this feature of the modern ObjC syntax until we drop support for 10.7 some day

no functional changes

Fixes #5548

macosx: don't use NSNotifcations to handle VLC's dialog callbacks, always perform NSAlert and friends on main thread

additionally, removed 2 clients of the manageInterface loop, which will be removed all together shortly

The code (with or without this patch) looks quite fishy though.
Fortunately, I do not understand Objective-C, so I can blindly assume
it is correct.