GitLab

When bs_read_ue() returned 2^32-1, computing (val + 1) as 'int'
overflowed. With this patch, the conversion from unsigned to signed is
performed after the division by two, so that the absolute value range
is always within limits of the signed 32-bits integer type.

Also use fast types since the function are meant to be inlined.

not intuitive, but something was divided by numerator

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

 - Use single precision trigonometric functions.
 - Compute sine and cosine only once.
 - Combine sine and cosine computation - on platforms allowing it.

That function assumed that:
- wchar_t and wint_t are the same: not true on Linux-i386,
- the locale encodes characters as UTF-8: not true on Windows.

This replaces its only occurrence with AppendString() and an explicit
UTF-8 sequence.

ref #17625

Ref #4815

There is nothing that guarantees that vlc_UrlParse will populate
url.psz_host after it has been invoked, as such we need to make sure
that we do not try to strdup with the value if it is NULL.

fixes #17630
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

The variable value is always zero as of bdc3ad38. Simplify accordingly.

These changes are a fixup of e2fb1043, in which a stupid brain-fart
caused me to invert the expression that is to see whether or not we
are at the end of stream.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

refs #17582

refs #17582

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

We need to propagate the projection mode set by the demux so to the
output-format. These changes also remove a stray semicolon due to the proximity
of the change (related to the pertinent one).
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

It is defined by the Spherical Video specification v1 from Google.
https://github.com/google/spatial-media/blob/master/docs/spherical-video-rfc.mdSigned-off-by: Thomas Guillem <thomas@gllm.fr>

The matrix is not used anywhere, and is unlikely to be used in the future; as
such these changes removes it (and its associated properties).
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

These added comments should make it easier to reason about the different
matrices used to do viewpoint related calculations.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

The previous implementations usage of input_item_GetName resulted in
unexpected data in the filename attribute (given that
input_item_GetName will first query vlc_meta_Title, and if present
return that).

These changes extracts the filename for a given item, including
support for trailing slashes (so that we do not get an empty filename
for a path such as file:///media/).

fixes #17611
Signed-off-by: Pierre Ynard <linkfanel@yahoo.fr>

The removed lines probably made some sense back in the days, but at
the current time things will fail to build in a horrible manner if
{gcc,g++}-4.2 is selected for CC and CXX (respectivelly).

Fixes #17614
Signed-off-by: Marvin Scholz <epirat07@gmail.com>