aballier authored Oct 06, 2008 and hartman committed Oct 06, 2008

See http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=c89bc900a3bf0d4c4c728ad378703970b4f14e18 for more details.

Dominique Leuenberger authored Sep 18, 2008 and Jean-Paul Saman committed Sep 19, 2008

Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

This improves readability a lot and prevent us from reinventing the wheel.

set qpmin/qpmax even without qp set.
more constant on x264 parameters handling.

* modules/codec/x264.c: fix threads=0 (auto) which is the default setting for VLC but wasn't propogated to x264 which kept using its default threads=1 (thanks pengvado for spotting the problem). This fix gives a major performance boost on multi cpu systems when using the default settings.

* modules/codec/x264.c: more user friendly version reporting of x264 (so no more confusion x264 core:58 would mean the system has 58 cores..)

* fix pthread support for x264 on win32
  - Not sure at all the configure.ac part is right, anyone more knowledgable, please check.

* modules/codec/x264.c: add satd exhaustive motion search (tesa) to the list of motion estimation algorithm options

* modules/codec/x264.c: set default for direct prediction size (direct-8x8) to -1 (smallest possible according to level); this fixes the direct 8x8 inference warning on level requirement in certain x264 setting combinations

    use size_t instead of int to represent sizes
    removes unused parameters from:
        block_BytestreamInit()
        mpeg4_audio/LOASSyncInfo()
        cinepak/cinepak_Getv1()
        speex/SendPacket()
        subsass/ParseColor()
        ffmpeg/postprocess/InitPostproc() & PostprocPict()
        dvbsub/YuvaYuvp() & encode_pixel_line_{2,4,8}bp()
        faad/DoReordering()

vlc_block_helper.h:
    use size_t, removes unused parameter from block_BytestreamInit()

struct filter_t:
    removes unused parameters from pf_picture_link() & pf_picture_unlink()
    
cmml: fix a segfault (p_item isn't an input item, despite the name) present for some months, proving that nobody did use that code ?

Missing some cases that I could not test.
Also ffmpeg/chroma.c is locked, so I can but leave it broken.
Fix is for the remaining modules is obvious and the issue is easy to detect.

   wrong for bpyramid, though).

 - Removed the gross SUPPRESSED hack
 - Remove support for strict deprecated aliases (that was not used anyway)

* modules/codec/x264.c: Add support for multipass encoding. Slightly alter stats behaviour to reflect same usage as x264 cli (only one stats file). Needs testing..

* modules/codec/x264.c: Revert [16936] (temporarily fix x264 encoding on darwin/x86 by disabling all CPU optimisations) as this shouldn't be a problem anymore..

* Headers in include must contain the structures and prototypes needed
  by the plugins and should be named vlc_*.
* Headers in include/vlc must contain the structures and prototypes
  needed by external libvlc clients

* Moved and renamed some things in headers. 
   - Removed vlc_cpu.h, vlc_error.h (merged in vlc_common)
   - Removed snapshot.h (merged in vlc_vout.h)
   - Removed vlc_spu.h (merged in vlc_osd.h)
   - Removed intf_eject.h and vlc_interaction.h (merged in vlc_interface)
   - Moved all internal headers to src
   - Merged vlc_video.h and video_output.h and move private things to src
   - Removed vlc/intf.h, vlc/aout.h, vlc/vout.h, vlc/decoder.h and vlc/input.h
     (meta headers for use in modules, and often implying too large 
     dependencies)
* Removed some useless dependencies
* Unexported a bunch of functions and structures used only in src/
  (--> Still some work here)
* Finally made input_thread_t and input_source_t (mostly) private. 
  Added input_GetItem to fetch the input_item of an input_thread
* Cleaned up deprecated entries in vlc_symbols.h and bumped up symbol 
  prefix

This commit has a 99% probability of breaking the build, 0.1% of killing
your cat and 0% of getting you hot chicks.