stream_UrlNew: avoid harmful vlc_object_find()
Four access plugins need access to the input at the moment. In all cases, it would misbehave if the input (item) of the main access was used. attachment: failing seems like the correct thing. I don't see a use for attachment from stream_UrlNew(). CDDA uses the input item to append child nodes for individual tracks. This is wrong in case of stream_UrlNew(), as the input items would be wrongly appended to the main access item. Like directory, FTP, etc, CCDA should probably return a playlist in this particular case. MMSH uses the input item for redirection. This would not work properly for stream_UrlNew(): it would rewrite the main access URL instead of the child stream URL. This failing seems actually safer. Handling the redirection within the MMS plugin would probably be better. VCDX uses the input item to fill disc-wide meta data from the GET_TITLE control request. It should use GET_META instead. In any case, it should not pollute the meta data of the main access. Bugs have been filed for the last 3 cases. Fortunately, I doubt any of these access plugins was ever used through stream_UrlNew().
Showing with 1 addition and 9 deletions