Commit f2ce1cab authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files

gain: setup filter_t only when successful

parent c1ab8edd
...@@ -79,15 +79,7 @@ vlc_module_end() ...@@ -79,15 +79,7 @@ vlc_module_end()
static int Open( vlc_object_t *p_this ) static int Open( vlc_object_t *p_this )
{ {
filter_t *p_filter = (filter_t *)p_this; filter_t *p_filter = (filter_t *)p_this;
filter_sys_t *p_sys; filter_sys_t *p_sys = vlc_object_create( p_this, sizeof( *p_sys ) );
if ( !AOUT_FMTS_IDENTICAL( &p_filter->fmt_in.audio, &p_filter->fmt_out.audio ) )
{
msg_Warn( p_filter, "bad input or output format" );
return VLC_EGENERIC;
}
p_sys = vlc_object_create( p_this, sizeof( *p_sys ) );
if( unlikely( p_sys == NULL ) ) if( unlikely( p_sys == NULL ) )
return VLC_ENOMEM; return VLC_ENOMEM;
...@@ -104,6 +96,7 @@ static int Open( vlc_object_t *p_this ) ...@@ -104,6 +96,7 @@ static int Open( vlc_object_t *p_this )
p_sys->f_gain = var_InheritFloat( p_filter->p_parent, "gain-value" ); p_sys->f_gain = var_InheritFloat( p_filter->p_parent, "gain-value" );
msg_Dbg( p_filter, "gain multiplier sets to %.2fx", p_sys->f_gain ); msg_Dbg( p_filter, "gain multiplier sets to %.2fx", p_sys->f_gain );
p_filter->fmt_out.audio = p_filter->fmt_in.audio;
p_filter->pf_audio_filter = Process; p_filter->pf_audio_filter = Process;
return VLC_SUCCESS; return VLC_SUCCESS;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment