Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Open sidebar
Steve Lhomme
VLC
Commits
cf5667bd
Commit
cf5667bd
authored
Mar 31, 2008
by
Rafaël Carré
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid leaking input items
parent
fdf1b8af
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
4 deletions
+3
-4
src/playlist/engine.c
src/playlist/engine.c
+1
-3
src/playlist/loadsave.c
src/playlist/loadsave.c
+2
-1
No files found.
src/playlist/engine.c
View file @
cf5667bd
...
...
@@ -478,11 +478,9 @@ void playlist_LastLoop( playlist_t *p_playlist )
playlist_MLDump
(
p_playlist
);
PL_LOCK
;
/* Go through all items, and simply free everything without caring
* about the tree structure. Do not decref, it will be done by doing
* the same thing on the input items array */
FOREACH_ARRAY
(
playlist_item_t
*
p_del
,
p_playlist
->
all_items
)
free
(
p_del
->
pp_children
);
vlc_gc_decref
(
p_del
->
p_input
);
free
(
p_del
);
FOREACH_END
();
ARRAY_RESET
(
p_playlist
->
all_items
);
...
...
src/playlist/loadsave.c
View file @
cf5667bd
...
...
@@ -151,6 +151,8 @@ int playlist_MLLoad( playlist_t *p_playlist )
p_playlist
->
p_ml_onelevel
->
p_input
=
p_playlist
->
p_ml_category
->
p_input
=
p_input
;
vlc_gc_incref
(
p_input
);
vlc_event_attach
(
&
p_input
->
event_manager
,
vlc_InputItemSubItemAdded
,
input_item_subitem_added
,
p_playlist
);
...
...
@@ -194,7 +196,6 @@ int playlist_MLDump( playlist_t *p_playlist )
stats_TimerStart
(
p_playlist
,
"ML Dump"
,
STATS_TIMER_ML_DUMP
);
playlist_Export
(
p_playlist
,
psz_dirname
,
p_playlist
->
p_ml_category
,
"export-xspf"
);
vlc_gc_decref
(
p_playlist
->
p_ml_category
->
p_input
);
stats_TimerStop
(
p_playlist
,
STATS_TIMER_ML_DUMP
);
return
VLC_SUCCESS
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment