lua: fix memory leak when getting/inherting string variable

a6fd99e4 · Rémi Denis-Courmont · b8ab8070 · a6fd99e4
Commit a6fd99e4 authored Nov 16, 2016 by Rémi Denis-Courmont
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

modules/lua/libs/variables.c modules/lua/libs/variables.c +8 -2

No files found.
--- a/modules/lua/libs/variables.c
+++ b/modules/lua/libs/variables.c
@@ -128,7 +128,10 @@ static int vlclua_var_inherit( lua_State *L )
        return 0;

    lua_pop( L, 2 );
-    return vlclua_pushvalue( L, i_type, val );
+    vlclua_pushvalue( L, i_type, val );
+    if( i_type == VLC_VAR_STRING )
+        free( val.psz_string );
+    return 1;
 }

 static int vlclua_var_get( lua_State *L )
@@ -142,7 +145,10 @@ static int vlclua_var_get( lua_State *L )
        return 0;

    lua_pop( L, 2 );
-    return vlclua_pushvalue( L, i_type, val );
+    vlclua_pushvalue( L, i_type, val );
+    if( i_type == VLC_VAR_STRING )
+        free( val.psz_string );
+    return 1;
 }

 static int vlclua_var_set( lua_State *L )