Commit a005a22e authored by zorglub's avatar zorglub

Clean up - convert todos to doxygen style

parent af10ead7
...@@ -32,7 +32,7 @@ void CmdPlaytreeDel::execute() ...@@ -32,7 +32,7 @@ void CmdPlaytreeDel::execute()
void CmdPlaytreeSort::execute() void CmdPlaytreeSort::execute()
{ {
// TODO: Choose sort method /// \todo Choose sort method/order - Need more commands
playlist_t *p_playlist = getIntf()->p_sys->p_playlist; playlist_t *p_playlist = getIntf()->p_sys->p_playlist;
vlc_mutex_lock( &p_playlist->object_lock ); vlc_mutex_lock( &p_playlist->object_lock );
playlist_view_t* p_view = playlist_ViewFind( p_playlist, p_playlist->status.i_view ); playlist_view_t* p_view = playlist_ViewFind( p_playlist, p_playlist->status.i_view );
......
...@@ -145,9 +145,7 @@ void CtrlTree::onUpdate( Subject<VarTree, tree_update*> &rTree, ...@@ -145,9 +145,7 @@ void CtrlTree::onUpdate( Subject<VarTree, tree_update*> &rTree,
} }
else if ( arg->i_type == 2 ) // Item-append else if ( arg->i_type == 2 ) // Item-append
{ {
/* TODO: Check if the item should be visible. If it is, makeImage /// \todo Check if the really is really visible in the view (we only check if it in the document)
* Else, do nothing
*/
if( arg->b_visible == true ) if( arg->b_visible == true )
{ {
makeImage(); makeImage();
...@@ -184,7 +182,6 @@ void CtrlTree::onUpdate( Subject<VarPercent, void*> &rPercent, void* arg) ...@@ -184,7 +182,6 @@ void CtrlTree::onUpdate( Subject<VarPercent, void*> &rPercent, void* arg)
void CtrlTree::onResize() void CtrlTree::onResize()
{ {
// FIXME : shouldn't be the same as the onUpdate function ... but i'm lazy
// Determine what is the first item to display // Determine what is the first item to display
VarTree::Iterator it = m_rTree.begin(); VarTree::Iterator it = m_rTree.begin();
...@@ -665,9 +662,7 @@ void CtrlTree::makeImage() ...@@ -665,9 +662,7 @@ void CtrlTree::makeImage()
} }
it = m_rTree.getNextVisibleItem( it ); it = m_rTree.getNextVisibleItem( it );
} }
/* TODO: Reposition percentage var to accomodate if it's not suitable anymore /// \todo Reposition percentage var to accomodate if it's not suitable anymore (if we expanded a node)
* (if we expanded a node)
*/
} }
VarTree::Iterator CtrlTree::findItemAtPos( int pos ) VarTree::Iterator CtrlTree::findItemAtPos( int pos )
......
...@@ -49,7 +49,7 @@ VarTree::VarTree( intf_thread_t *pIntf, VarTree *pParent, int id, ...@@ -49,7 +49,7 @@ VarTree::VarTree( intf_thread_t *pIntf, VarTree *pParent, int id,
VarTree::~VarTree() VarTree::~VarTree()
{ {
// TODO : check that children are deleted /// \todo check that children are deleted
} }
void VarTree::add( int id, const UStringPtr &rcString, bool selected, void VarTree::add( int id, const UStringPtr &rcString, bool selected,
......
...@@ -65,7 +65,7 @@ class VarTree: public Variable, public Subject<VarTree, tree_update*> ...@@ -65,7 +65,7 @@ class VarTree: public Variable, public Subject<VarTree, tree_update*>
/// Remove all elements from the children's list /// Remove all elements from the children's list
virtual void clear(); virtual void clear();
/// FIXME should be private /// \todo Use accessors for these fields ?
int m_id; int m_id;
UStringPtr m_cString; UStringPtr m_cString;
bool m_selected; bool m_selected;
......
...@@ -54,7 +54,6 @@ Playtree::Playtree( intf_thread_t *pIntf ): VarTree( pIntf ) ...@@ -54,7 +54,6 @@ Playtree::Playtree( intf_thread_t *pIntf ): VarTree( pIntf )
Playtree::~Playtree() Playtree::~Playtree()
{ {
if( iconvHandle != (vlc_iconv_t) - 1 ) vlc_iconv_close( iconvHandle ); if( iconvHandle != (vlc_iconv_t) - 1 ) vlc_iconv_close( iconvHandle );
// TODO : check that everything is destroyed
} }
void Playtree::delSelected() void Playtree::delSelected()
...@@ -79,7 +78,7 @@ void Playtree::delSelected() ...@@ -79,7 +78,7 @@ void Playtree::delSelected()
} }
} }
} }
// TODO: Do this better /// \todo Do this better (handle item-deleted)
buildTree(); buildTree();
tree_update descr; tree_update descr;
descr.i_type = 1; descr.i_type = 1;
...@@ -188,10 +187,9 @@ void Playtree::buildTree() ...@@ -188,10 +187,9 @@ void Playtree::buildTree()
playlist_view_t *p_view; playlist_view_t *p_view;
p_view = playlist_ViewFind( m_pPlaylist, VIEW_CATEGORY ); p_view = playlist_ViewFind( m_pPlaylist, VIEW_CATEGORY );
/* TODO : let the user chose the view type */ /// \todo let the user chose the view
clear(); clear();
/* XXX : do we need Playlist::clear() instead of VarTree::clear() ? */
/* Set the root's name */ /* Set the root's name */
UString *pName = new UString( getIntf(), p_view->p_root->input.psz_name ); UString *pName = new UString( getIntf(), p_view->p_root->input.psz_name );
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment