Commit 9638c71a authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files

Disable vout_RequestWindow. It has never worked properly

Some people should have read some documentation about threading before
they did 1000+ commits. Yes, I am obviously annoyed. I have been fixing
VLC for 18 months because of these "great former developers".
parent bd054d30
...@@ -107,6 +107,19 @@ void *vout_RequestWindow( vout_thread_t *p_vout, ...@@ -107,6 +107,19 @@ void *vout_RequestWindow( vout_thread_t *p_vout,
var_Get( p_vout->p_libvlc, "drawable", &val ); var_Get( p_vout->p_libvlc, "drawable", &val );
if( val.i_int ) return (void *)(intptr_t)val.i_int; if( val.i_int ) return (void *)(intptr_t)val.i_int;
#if 0
* This code is utter crap w.r.t. threading. And it has always been.
* First, one cannot invoke callbacks from another thread's object.
* Not without a well-defined locking convention.
* Second, this would need to "wait" for the interface to be ready.
* Otherwise, the availability of the embded window would become
* time-dependent.
* In the past, this kind of things worked by accident. This time is over.
* -- Courmisch, 12 Jun 2008
/* Find if the main interface supports embedding */ /* Find if the main interface supports embedding */
p_list = vlc_list_find( p_vout, VLC_OBJECT_INTF, FIND_ANYWHERE ); p_list = vlc_list_find( p_vout, VLC_OBJECT_INTF, FIND_ANYWHERE );
if( !p_list ) return NULL; if( !p_list ) return NULL;
...@@ -134,6 +147,9 @@ void *vout_RequestWindow( vout_thread_t *p_vout, ...@@ -134,6 +147,9 @@ void *vout_RequestWindow( vout_thread_t *p_vout,
else p_vout->p_parent_intf = p_intf; else p_vout->p_parent_intf = p_intf;
return p_window; return p_window;
return NULL;
} }
void vout_ReleaseWindow( vout_thread_t *p_vout, void *p_window ) void vout_ReleaseWindow( vout_thread_t *p_vout, void *p_window )
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment