Commit 78964d87 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files

Fix off-by-one overflow and simplify

parent 4f58d06b
...@@ -1003,21 +1003,20 @@ static int StateChanged( vlc_object_t *p_this, char const *psz_cmd, ...@@ -1003,21 +1003,20 @@ static int StateChanged( vlc_object_t *p_this, char const *psz_cmd,
p_playlist = vlc_object_find( p_input, VLC_OBJECT_PLAYLIST, FIND_PARENT ); p_playlist = vlc_object_find( p_input, VLC_OBJECT_PLAYLIST, FIND_PARENT );
if( p_playlist ) if( p_playlist )
{ {
char cmd[5] = ""; char cmd[6];
switch( p_playlist->status.i_status ) switch( p_playlist->status.i_status )
{ {
case PLAYLIST_STOPPED: case PLAYLIST_STOPPED:
strncpy( &cmd[0], "stop", 4); strcpy( cmd, "stop" );
cmd[4] = '\0';
break; break;
case PLAYLIST_RUNNING: case PLAYLIST_RUNNING:
strncpy( &cmd[0], "play", 4); strcpy( cmd, "play" );
cmd[4] = '\0';
break; break;
case PLAYLIST_PAUSED: case PLAYLIST_PAUSED:
strncpy( &cmd[0], "pause", 5); strcpy( cmd, "pause" );
cmd[5] = '\0';
break; break;
default:
cmd[0] = '\0';
} /* var_GetInteger( p_input, "state" ) */ } /* var_GetInteger( p_input, "state" ) */
msg_rc( STATUS_CHANGE "( %s state: %d )", &cmd[0], newval.i_int ); msg_rc( STATUS_CHANGE "( %s state: %d )", &cmd[0], newval.i_int );
vlc_object_release( p_playlist ); vlc_object_release( p_playlist );
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment