Commit 5290dabe authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

video output: fix offsets and visible dimensions of filtered video

This parameter copy was working around broken format-changing video
filters, but it broke filters updating the format correctly
(deinterlace, transform and croppadd).

Refs #10745. Note that transform is still not working correctly: the
aspect ratio is broken for transpositation and quarter rotations. This
latent bug should vanish with the video orientation support later.
Otherwise the proper fix is to allow the filters chain to change the
format.
parent 2d39e8f9
......@@ -795,7 +795,7 @@ static void ThreadChangeFilters(vout_thread_t *vout,
fmt_current = *filter_chain_GetFmtOut(chain);
vlc_array_clear(array);
}
VideoFormatCopyCropAr(&fmt_target.video, &fmt_current.video);
if (!es_format_IsSimilar(&fmt_current, &fmt_target)) {
msg_Dbg(vout, "Adding a filter to compensate for format changes");
if (!filter_chain_AppendFilter(vout->p->filter.chain_interactive, NULL, NULL,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment