Commit 4d540e48 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files

contribs: fix error handling while compressing tar archives

When the shell evaluates 'foo | bar', it returns the status of bar, not
foo. 'foo' can fail silently: so long as 'bar' succeeds, make will
not notice and will therefore not delete the target.

So lets use 'tar cv(z|j|J)' instead of 'tar cv | (gzip|bzip2|xz)'.
parent 5dfff129
...@@ -122,7 +122,7 @@ ffmpeg-$(FFMPEG_VERSION).tar.gz: ...@@ -122,7 +122,7 @@ ffmpeg-$(FFMPEG_VERSION).tar.gz:
$(TARBALLS)/ffmpeg-svn.tar.gz: $(TARBALLS)/ffmpeg-svn.tar.gz:
$(SVN) export $(FFMPEG_SVN) ffmpeg-svn $(SVN) export $(FFMPEG_SVN) ffmpeg-svn
tar cv ffmpeg-svn | gzip > $@ tar cvz ffmpeg-svn > $@
...@@ -7,7 +7,7 @@ endif ...@@ -7,7 +7,7 @@ endif
$(TARBALLS)/tremor-svn.tar.xz: $(TARBALLS)/tremor-svn.tar.xz:
rm -Rf tremor-svn rm -Rf tremor-svn
$(SVN) export tremor-svn $(SVN) export tremor-svn
tar cv tremor-svn | xz > $@ tar cvJ tremor-svn > $@
.sum-tremor: tremor-svn.tar.xz .sum-tremor: tremor-svn.tar.xz
$(warning Integrity check skipped.) $(warning Integrity check skipped.)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment