From 0a59bb70bb494cdd47df6d7edbd85d00e4864152 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Paul=20K=C3=BChne?= Date: Fri, 19 Jun 2015 15:27:08 +0200 Subject: [PATCH] iOS dialog provider: fix retain cycle --- modules/gui/ios_dialog_provider/dialogProvider.m | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/gui/ios_dialog_provider/dialogProvider.m b/modules/gui/ios_dialog_provider/dialogProvider.m index 8b9e1f8083..9deacf20bc 100644 --- a/modules/gui/ios_dialog_provider/dialogProvider.m +++ b/modules/gui/ios_dialog_provider/dialogProvider.m @@ -226,6 +226,7 @@ static int DisplayLogin(vlc_object_t *p_this, const char *type, vlc_value_t prev [dict setObject:@(no) forKey:@"no"]; if (cancel) [dict setObject:@(cancel) forKey:@"cancel"]; + [dict retain]; return dict; } @@ -238,6 +239,7 @@ static int DisplayLogin(vlc_object_t *p_this, const char *type, vlc_value_t prev VLCBlockingAlertView *alert = [[VLCBlockingAlertView alloc] initWithTitle:[dialog objectForKey:@"title"] message:[dialog objectForKey:@"message"] delegate:nil cancelButtonTitle:@"OK" otherButtonTitles:nil]; alert.completion = ^(BOOL cancelled, NSInteger buttonIndex) { [alert release]; + [dialog release]; }; [alert show]; } @@ -249,6 +251,7 @@ static int DisplayLogin(vlc_object_t *p_this, const char *type, vlc_value_t prev VLCBlockingAlertView *alert = [[VLCBlockingAlertView alloc] initWithTitle:[dialog objectForKey:@"title"] message:[dialog objectForKey:@"message"] delegate:nil cancelButtonTitle:@"OK" otherButtonTitles:nil]; alert.completion = ^(BOOL cancelled, NSInteger buttonIndex) { [alert release]; + [dialog release]; }; [alert show]; } @@ -276,6 +279,7 @@ static int DisplayLogin(vlc_object_t *p_this, const char *type, vlc_value_t prev dispatch_semaphore_wait(sema, DISPATCH_TIME_FOREVER); [alert release]; + [dialog release]; return @(ret); } @@ -309,6 +313,7 @@ static int DisplayLogin(vlc_object_t *p_this, const char *type, vlc_value_t prev dispatch_semaphore_wait(sema, DISPATCH_TIME_FOREVER); [alert release]; + [dialog release]; return dict; } -- GitLab