video_output.c 51.4 KB
Newer Older
1
/*****************************************************************************
Michel Kaempf's avatar
Michel Kaempf committed
2
 * video_output.c : video output thread
3
 *
Michel Kaempf's avatar
Michel Kaempf committed
4 5
 * This module describes the programming interface for video output threads.
 * It includes functions allowing to open a new thread, send pictures to a
6 7
 * thread, and destroy a previously oppened video output thread.
 *****************************************************************************
Jean-Baptiste Kempf's avatar
LGPL  
Jean-Baptiste Kempf committed
8
 * Copyright (C) 2000-2007 VLC authors and VideoLAN
Gildas Bazin's avatar
Gildas Bazin committed
9
 * $Id$
10
 *
Sam Hocevar's avatar
 
Sam Hocevar committed
11
 * Authors: Vincent Seguin <seguin@via.ecp.fr>
12
 *          Gildas Bazin <gbazin@videolan.org>
13
 *          Laurent Aimar <fenrir _AT_ videolan _DOT_ org>
14
 *
Jean-Baptiste Kempf's avatar
LGPL  
Jean-Baptiste Kempf committed
15 16 17
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation; either version 2.1 of the License, or
18
 * (at your option) any later version.
19
 *
20 21
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
Jean-Baptiste Kempf's avatar
LGPL  
Jean-Baptiste Kempf committed
22 23
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Lesser General Public License for more details.
24
 *
Jean-Baptiste Kempf's avatar
LGPL  
Jean-Baptiste Kempf committed
25 26 27
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
28
 *****************************************************************************/
Michel Kaempf's avatar
Michel Kaempf committed
29

30
/*****************************************************************************
Michel Kaempf's avatar
Michel Kaempf committed
31
 * Preamble
32
 *****************************************************************************/
33 34 35 36
#ifdef HAVE_CONFIG_H
# include "config.h"
#endif

37
#include <vlc_common.h>
38

39
#include <stdlib.h>                                                /* free() */
40
#include <string.h>
41
#include <assert.h>
Vincent Seguin's avatar
Vincent Seguin committed
42

Clément Stenac's avatar
Clément Stenac committed
43
#include <vlc_vout.h>
44

Clément Stenac's avatar
Clément Stenac committed
45
#include <vlc_filter.h>
46
#include <vlc_vout_osd.h>
47
#include <vlc_image.h>
Clément Stenac's avatar
Clément Stenac committed
48

49
#include <libvlc.h>
Laurent Aimar's avatar
Laurent Aimar committed
50
#include "vout_internal.h"
51
#include "interlacing.h"
52
#include "display.h"
53

54
/*****************************************************************************
Michel Kaempf's avatar
Michel Kaempf committed
55
 * Local prototypes
56
 *****************************************************************************/
57 58
static void *Thread(void *);
static void VoutDestructor(vlc_object_t *);
59

60 61 62 63
/* Maximum delay between 2 displayed pictures.
 * XXX it is needed for now but should be removed in the long term.
 */
#define VOUT_REDISPLAY_DELAY (INT64_C(80000))
64

65 66 67 68
/**
 * Late pictures having a delay higher than this value are thrashed.
 */
#define VOUT_DISPLAY_LATE_THRESHOLD (INT64_C(20000))
69 70

/* Better be in advance when awakening than late... */
71
#define VOUT_MWAIT_TOLERANCE (INT64_C(4000))
72

73 74 75
/* */
static int VoutValidateFormat(video_format_t *dst,
                              const video_format_t *src)
76
{
77 78
    if (src->i_width <= 0  || src->i_width  > 8192 ||
        src->i_height <= 0 || src->i_height > 8192)
79 80 81
        return VLC_EGENERIC;
    if (src->i_sar_num <= 0 || src->i_sar_den <= 0)
        return VLC_EGENERIC;
82

83 84 85 86 87 88 89 90 91 92
    /* */
    video_format_Copy(dst, src);
    dst->i_chroma = vlc_fourcc_GetCodec(VIDEO_ES, src->i_chroma);
    vlc_ureduce( &dst->i_sar_num, &dst->i_sar_den,
                 src->i_sar_num,  src->i_sar_den, 50000 );
    if (dst->i_sar_num <= 0 || dst->i_sar_den <= 0) {
        dst->i_sar_num = 1;
        dst->i_sar_den = 1;
    }
    video_format_FixRgb(dst);
93
    return VLC_SUCCESS;
94
}
95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110
static void VideoFormatCopyCropAr(video_format_t *dst,
                                  const video_format_t *src)
{
    video_format_CopyCrop(dst, src);
    dst->i_sar_num = src->i_sar_num;
    dst->i_sar_den = src->i_sar_den;
}
static bool VideoFormatIsCropArEqual(video_format_t *dst,
                                     const video_format_t *src)
{
    return dst->i_sar_num * src->i_sar_den == dst->i_sar_den * src->i_sar_num &&
           dst->i_x_offset       == src->i_x_offset &&
           dst->i_y_offset       == src->i_y_offset &&
           dst->i_visible_width  == src->i_visible_width &&
           dst->i_visible_height == src->i_visible_height;
}
111

112 113
static vout_thread_t *VoutCreate(vlc_object_t *object,
                                 const vout_configuration_t *cfg)
Michel Kaempf's avatar
Michel Kaempf committed
114
{
115
    video_format_t original;
116
    if (VoutValidateFormat(&original, cfg->fmt))
117 118
        return NULL;

119
    /* Allocate descriptor */
Laurent Aimar's avatar
Laurent Aimar committed
120 121
    vout_thread_t *vout = vlc_custom_create(object,
                                            sizeof(*vout) + sizeof(*vout->p),
122
                                            "video output");
Laurent Aimar's avatar
Laurent Aimar committed
123
    if (!vout) {
124
        video_format_Clean(&original);
125 126 127
        return NULL;
    }

128
    /* */
Laurent Aimar's avatar
Laurent Aimar committed
129
    vout->p = (vout_thread_sys_t*)&vout[1];
130

Laurent Aimar's avatar
Laurent Aimar committed
131
    vout->p->original = original;
132
    vout->p->dpb_size = cfg->dpb_size;
133

Laurent Aimar's avatar
Laurent Aimar committed
134 135
    vout_control_Init(&vout->p->control);
    vout_control_PushVoid(&vout->p->control, VOUT_CONTROL_INIT);
136

Laurent Aimar's avatar
Laurent Aimar committed
137
    vout_statistic_Init(&vout->p->statistic);
138

Laurent Aimar's avatar
Laurent Aimar committed
139
    vout_snapshot_Init(&vout->p->snapshot);
140

Gildas Bazin's avatar
 
Gildas Bazin committed
141
    /* Initialize locks */
Laurent Aimar's avatar
Laurent Aimar committed
142
    vlc_mutex_init(&vout->p->picture_lock);
143
    vlc_mutex_init(&vout->p->filter.lock);
144
    vlc_mutex_init(&vout->p->spu_lock);
Gildas Bazin's avatar
 
Gildas Bazin committed
145

146
    /* Initialize subpicture unit */
Laurent Aimar's avatar
Laurent Aimar committed
147
    vout->p->spu = spu_Create(vout);
148

149
    /* Take care of some "interface/control" related initialisations */
Laurent Aimar's avatar
Laurent Aimar committed
150
    vout_IntfInit(vout);
Gildas Bazin's avatar
 
Gildas Bazin committed
151

152 153 154
    vout->p->title.show     = var_InheritBool(vout, "video-title-show");
    vout->p->title.timeout  = var_InheritInteger(vout, "video-title-timeout");
    vout->p->title.position = var_InheritInteger(vout, "video-title-position");
155

156
    /* Get splitter name if present */
157
    char *splitter_name = var_InheritString(vout, "video-splitter");
158
    if (splitter_name && *splitter_name) {
Laurent Aimar's avatar
Laurent Aimar committed
159
        vout->p->splitter_name = splitter_name;
160
    } else {
Laurent Aimar's avatar
Laurent Aimar committed
161
        free(splitter_name);
Sam Hocevar's avatar
 
Sam Hocevar committed
162 163
    }

Laurent Aimar's avatar
Laurent Aimar committed
164
    /* */
Laurent Aimar's avatar
Laurent Aimar committed
165
    vout_InitInterlacingSupport(vout, vout->p->displayed.is_interlaced);
Laurent Aimar's avatar
Laurent Aimar committed
166 167

    /* */
Laurent Aimar's avatar
Laurent Aimar committed
168
    vlc_object_set_destructor(vout, VoutDestructor);
Gildas Bazin's avatar
 
Gildas Bazin committed
169

170
    /* */
Laurent Aimar's avatar
Laurent Aimar committed
171 172
    if (vlc_clone(&vout->p->thread, Thread, vout,
                  VLC_THREAD_PRIORITY_OUTPUT)) {
Laurent Aimar's avatar
Laurent Aimar committed
173
        spu_Destroy(vout->p->spu);
Laurent Aimar's avatar
Laurent Aimar committed
174
        vlc_object_release(vout);
175 176 177
        return NULL;
    }

Laurent Aimar's avatar
Laurent Aimar committed
178
    vout_control_WaitEmpty(&vout->p->control);
179

Laurent Aimar's avatar
Laurent Aimar committed
180 181 182
    if (vout->p->dead) {
        msg_Err(vout, "video output creation failed");
        vout_CloseAndRelease(vout);
183
        return NULL;
184
    }
Michel Kaempf's avatar
Michel Kaempf committed
185

186 187
    vout->p->input = cfg->input;
    if (vout->p->input)
Laurent Aimar's avatar
Laurent Aimar committed
188
        spu_Attach(vout->p->spu, vout->p->input, true);
189

Laurent Aimar's avatar
Laurent Aimar committed
190
    return vout;
Michel Kaempf's avatar
Michel Kaempf committed
191 192
}

Rafaël Carré's avatar
Rafaël Carré committed
193 194
#undef vout_Request
vout_thread_t *vout_Request(vlc_object_t *object,
195 196 197
                              const vout_configuration_t *cfg)
{
    vout_thread_t *vout = cfg->vout;
Laurent Aimar's avatar
Laurent Aimar committed
198
    if (cfg->change_fmt && !cfg->fmt) {
199 200 201 202 203 204 205
        if (vout)
            vout_CloseAndRelease(vout);
        return NULL;
    }

    /* If a vout is provided, try reusing it */
    if (vout) {
206 207
        if (vout->p->input != cfg->input) {
            if (vout->p->input)
Laurent Aimar's avatar
Laurent Aimar committed
208
                spu_Attach(vout->p->spu, vout->p->input, false);
209 210
            vout->p->input = cfg->input;
            if (vout->p->input)
Laurent Aimar's avatar
Laurent Aimar committed
211
                spu_Attach(vout->p->spu, vout->p->input, true);
212
        }
213

Laurent Aimar's avatar
Laurent Aimar committed
214 215 216 217 218 219 220 221
        if (cfg->change_fmt) {
            vout_control_cmd_t cmd;
            vout_control_cmd_Init(&cmd, VOUT_CONTROL_REINIT);
            cmd.u.cfg = cfg;

            vout_control_Push(&vout->p->control, &cmd);
            vout_control_WaitEmpty(&vout->p->control);
        }
222 223 224

        if (!vout->p->dead) {
            msg_Dbg(object, "reusing provided vout");
225
            vout_IntfReinit(vout);
226 227 228 229 230 231 232 233 234
            return vout;
        }
        vout_CloseAndRelease(vout);

        msg_Warn(object, "cannot reuse provided vout");
    }
    return VoutCreate(object, cfg);
}

Laurent Aimar's avatar
Laurent Aimar committed
235
void vout_Close(vout_thread_t *vout)
236
{
Laurent Aimar's avatar
Laurent Aimar committed
237
    assert(vout);
238

239
    if (vout->p->input)
Laurent Aimar's avatar
Laurent Aimar committed
240
        spu_Attach(vout->p->spu, vout->p->input, false);
241

Laurent Aimar's avatar
Laurent Aimar committed
242
    vout_snapshot_End(&vout->p->snapshot);
243

Laurent Aimar's avatar
Laurent Aimar committed
244 245
    vout_control_PushVoid(&vout->p->control, VOUT_CONTROL_CLEAN);
    vlc_join(vout->p->thread, NULL);
246

247
    vlc_mutex_lock(&vout->p->spu_lock);
Laurent Aimar's avatar
Laurent Aimar committed
248 249
    spu_Destroy(vout->p->spu);
    vout->p->spu = NULL;
250
    vlc_mutex_unlock(&vout->p->spu_lock);
251 252 253
}

/* */
Laurent Aimar's avatar
Laurent Aimar committed
254
static void VoutDestructor(vlc_object_t *object)
255
{
Laurent Aimar's avatar
Laurent Aimar committed
256
    vout_thread_t *vout = (vout_thread_t *)object;
257

258
    /* Make sure the vout was stopped first */
Laurent Aimar's avatar
Laurent Aimar committed
259
    //assert(!vout->p_module);
260

Laurent Aimar's avatar
Laurent Aimar committed
261
    free(vout->p->splitter_name);
262

263
    /* Destroy the locks */
264
    vlc_mutex_destroy(&vout->p->spu_lock);
Laurent Aimar's avatar
Laurent Aimar committed
265
    vlc_mutex_destroy(&vout->p->picture_lock);
266
    vlc_mutex_destroy(&vout->p->filter.lock);
Laurent Aimar's avatar
Laurent Aimar committed
267
    vout_control_Clean(&vout->p->control);
268

269
    /* */
Laurent Aimar's avatar
Laurent Aimar committed
270
    vout_statistic_Clean(&vout->p->statistic);
271

272
    /* */
Laurent Aimar's avatar
Laurent Aimar committed
273
    vout_snapshot_Clean(&vout->p->snapshot);
274

Laurent Aimar's avatar
Laurent Aimar committed
275
    video_format_Clean(&vout->p->original);
Michel Kaempf's avatar
Michel Kaempf committed
276 277
}

Laurent Aimar's avatar
Laurent Aimar committed
278
/* */
279
void vout_ChangePause(vout_thread_t *vout, bool is_paused, mtime_t date)
Laurent Aimar's avatar
Laurent Aimar committed
280
{
281 282 283 284 285
    vout_control_cmd_t cmd;
    vout_control_cmd_Init(&cmd, VOUT_CONTROL_PAUSE);
    cmd.u.pause.is_on = is_paused;
    cmd.u.pause.date  = date;
    vout_control_Push(&vout->p->control, &cmd);
Laurent Aimar's avatar
Laurent Aimar committed
286

287
    vout_control_WaitEmpty(&vout->p->control);
Laurent Aimar's avatar
Laurent Aimar committed
288
}
289

Laurent Aimar's avatar
Laurent Aimar committed
290
void vout_GetResetStatistic(vout_thread_t *vout, int *displayed, int *lost)
291
{
Laurent Aimar's avatar
Laurent Aimar committed
292
    vout_statistic_GetReset( &vout->p->statistic, displayed, lost );
293
}
294

295
void vout_Flush(vout_thread_t *vout, mtime_t date)
296
{
297 298
    vout_control_PushTime(&vout->p->control, VOUT_CONTROL_FLUSH, date);
    vout_control_WaitEmpty(&vout->p->control);
299
}
300

301
void vout_Reset(vout_thread_t *vout)
302
{
303 304
    vout_control_PushVoid(&vout->p->control, VOUT_CONTROL_RESET);
    vout_control_WaitEmpty(&vout->p->control);
305
}
306

307 308 309 310 311 312 313 314 315 316 317 318 319
bool vout_IsEmpty(vout_thread_t *vout)
{
    vlc_mutex_lock(&vout->p->picture_lock);

    picture_t *picture = picture_fifo_Peek(vout->p->decoder_fifo);
    if (picture)
        picture_Release(picture);

    vlc_mutex_unlock(&vout->p->picture_lock);

    return !picture;
}

320
void vout_FixLeaks( vout_thread_t *vout )
321 322 323 324 325 326
{
    vlc_mutex_lock(&vout->p->picture_lock);

    picture_t *picture = picture_fifo_Peek(vout->p->decoder_fifo);
    if (!picture) {
        picture = picture_pool_Get(vout->p->decoder_pool);
327
    }
328 329 330 331 332 333

    if (picture) {
        picture_Release(picture);
        /* Not all pictures has been displayed yet or some are
         * free */
        vlc_mutex_unlock(&vout->p->picture_lock);
334 335 336
        return;
    }

337 338 339
    /* There is no reason that no pictures are available, force one
     * from the pool, becarefull with it though */
    msg_Err(vout, "pictures leaked, trying to workaround");
340

341 342
    /* */
    picture_pool_NonEmpty(vout->p->decoder_pool, false);
Laurent Aimar's avatar
Laurent Aimar committed
343

344
    vlc_mutex_unlock(&vout->p->picture_lock);
345
}
346
void vout_NextPicture(vout_thread_t *vout, mtime_t *duration)
347
{
348 349 350
    vout_control_cmd_t cmd;
    vout_control_cmd_Init(&cmd, VOUT_CONTROL_STEP);
    cmd.u.time_ptr = duration;
351

352 353
    vout_control_Push(&vout->p->control, &cmd);
    vout_control_WaitEmpty(&vout->p->control);
354
}
355

356
void vout_DisplayTitle(vout_thread_t *vout, const char *title)
357
{
358 359
    assert(title);
    vout_control_PushString(&vout->p->control, VOUT_CONTROL_OSD_TITLE, title);
360
}
361

362 363
void vout_PutSubpicture( vout_thread_t *vout, subpicture_t *subpic )
{
364 365 366 367 368
    vout_control_cmd_t cmd;
    vout_control_cmd_Init(&cmd, VOUT_CONTROL_SUBPICTURE);
    cmd.u.subpicture = subpic;

    vout_control_Push(&vout->p->control, &cmd);
369 370 371
}
int vout_RegisterSubpictureChannel( vout_thread_t *vout )
{
372 373 374
    int channel = SPU_DEFAULT_CHANNEL;

    vlc_mutex_lock(&vout->p->spu_lock);
Laurent Aimar's avatar
Laurent Aimar committed
375 376
    if (vout->p->spu)
        channel = spu_RegisterChannel(vout->p->spu);
377 378 379
    vlc_mutex_unlock(&vout->p->spu_lock);

    return channel;
380 381 382
}
void vout_FlushSubpictureChannel( vout_thread_t *vout, int channel )
{
383 384
    vout_control_PushInteger(&vout->p->control, VOUT_CONTROL_FLUSH_SUBPICTURE,
                             channel);
385 386
}

387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402
/**
 * It retreives a picture from the vout or NULL if no pictures are
 * available yet.
 *
 * You MUST call vout_PutPicture or vout_ReleasePicture on it.
 *
 * You may use vout_HoldPicture(paired with vout_ReleasePicture) to keep a
 * read-only reference.
 */
picture_t *vout_GetPicture(vout_thread_t *vout)
{
    /* Get lock */
    vlc_mutex_lock(&vout->p->picture_lock);
    picture_t *picture = picture_pool_Get(vout->p->decoder_pool);
    if (picture) {
        picture_Reset(picture);
403
        VideoFormatCopyCropAr(&picture->format, &vout->p->original);
404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456
    }
    vlc_mutex_unlock(&vout->p->picture_lock);

    return picture;
}

/**
 * It gives to the vout a picture to be displayed.
 *
 * The given picture MUST comes from vout_GetPicture.
 *
 * Becareful, after vout_PutPicture is called, picture_t::p_next cannot be
 * read/used.
 */
void vout_PutPicture(vout_thread_t *vout, picture_t *picture)
{
    vlc_mutex_lock(&vout->p->picture_lock);

    picture->p_next = NULL;
    picture_fifo_Push(vout->p->decoder_fifo, picture);

    vlc_mutex_unlock(&vout->p->picture_lock);

    vout_control_Wake(&vout->p->control);
}

/**
 * It releases a picture retreived by vout_GetPicture.
 */
void vout_ReleasePicture(vout_thread_t *vout, picture_t *picture)
{
    vlc_mutex_lock(&vout->p->picture_lock);

    picture_Release(picture);

    vlc_mutex_unlock(&vout->p->picture_lock);

    vout_control_Wake(&vout->p->control);
}

/**
 * It increment the reference counter of a picture retreived by
 * vout_GetPicture.
 */
void vout_HoldPicture(vout_thread_t *vout, picture_t *picture)
{
    vlc_mutex_lock(&vout->p->picture_lock);

    picture_Hold(picture);

    vlc_mutex_unlock(&vout->p->picture_lock);
}

457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473
/* */
int vout_GetSnapshot(vout_thread_t *vout,
                     block_t **image_dst, picture_t **picture_dst,
                     video_format_t *fmt,
                     const char *type, mtime_t timeout)
{
    picture_t *picture = vout_snapshot_Get(&vout->p->snapshot, timeout);
    if (!picture) {
        msg_Err(vout, "Failed to grab a snapshot");
        return VLC_EGENERIC;
    }

    if (image_dst) {
        vlc_fourcc_t codec = VLC_CODEC_PNG;
        if (type && image_Type2Fourcc(type))
            codec = image_Type2Fourcc(type);

474 475
        const int override_width  = var_InheritInteger(vout, "snapshot-width");
        const int override_height = var_InheritInteger(vout, "snapshot-height");
476 477 478 479 480 481 482 483 484 485 486 487 488 489 490

        if (picture_Export(VLC_OBJECT(vout), image_dst, fmt,
                           picture, codec, override_width, override_height)) {
            msg_Err(vout, "Failed to convert image for snapshot");
            picture_Release(picture);
            return VLC_EGENERIC;
        }
    }
    if (picture_dst)
        *picture_dst = picture;
    else
        picture_Release(picture);
    return VLC_SUCCESS;
}

491 492 493 494 495 496
void vout_ChangeAspectRatio( vout_thread_t *p_vout,
                             unsigned int i_num, unsigned int i_den )
{
    vout_ControlChangeSampleAspectRatio( p_vout, i_num, i_den );
}

497 498 499 500 501 502
/* vout_Control* are usable by anyone at anytime */
void vout_ControlChangeFullscreen(vout_thread_t *vout, bool fullscreen)
{
    vout_control_PushBool(&vout->p->control, VOUT_CONTROL_FULLSCREEN,
                          fullscreen);
}
503
void vout_ControlChangeWindowState(vout_thread_t *vout, unsigned st)
504
{
505
    vout_control_PushInteger(&vout->p->control, VOUT_CONTROL_WINDOW_STATE, st);
506 507 508 509 510 511 512 513 514 515 516
}
void vout_ControlChangeDisplayFilled(vout_thread_t *vout, bool is_filled)
{
    vout_control_PushBool(&vout->p->control, VOUT_CONTROL_DISPLAY_FILLED,
                          is_filled);
}
void vout_ControlChangeZoom(vout_thread_t *vout, int num, int den)
{
    vout_control_PushPair(&vout->p->control, VOUT_CONTROL_ZOOM,
                          num, den);
}
517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
void vout_ControlChangeSampleAspectRatio(vout_thread_t *vout,
                                         unsigned num, unsigned den)
{
    vout_control_PushPair(&vout->p->control, VOUT_CONTROL_ASPECT_RATIO,
                          num, den);
}
void vout_ControlChangeCropRatio(vout_thread_t *vout,
                                 unsigned num, unsigned den)
{
    vout_control_PushPair(&vout->p->control, VOUT_CONTROL_CROP_RATIO,
                          num, den);
}
void vout_ControlChangeCropWindow(vout_thread_t *vout,
                                  int x, int y, int width, int height)
{
    vout_control_cmd_t cmd;
    vout_control_cmd_Init(&cmd, VOUT_CONTROL_CROP_WINDOW);
534 535 536 537
    cmd.u.window.x      = __MAX(x, 0);
    cmd.u.window.y      = __MAX(y, 0);
    cmd.u.window.width  = __MAX(width, 0);
    cmd.u.window.height = __MAX(height, 0);
538 539 540 541 542 543 544 545

    vout_control_Push(&vout->p->control, &cmd);
}
void vout_ControlChangeCropBorder(vout_thread_t *vout,
                                  int left, int top, int right, int bottom)
{
    vout_control_cmd_t cmd;
    vout_control_cmd_Init(&cmd, VOUT_CONTROL_CROP_BORDER);
546 547 548 549
    cmd.u.border.left   = __MAX(left, 0);
    cmd.u.border.top    = __MAX(top, 0);
    cmd.u.border.right  = __MAX(right, 0);
    cmd.u.border.bottom = __MAX(bottom, 0);
550 551 552

    vout_control_Push(&vout->p->control, &cmd);
}
553 554 555 556 557
void vout_ControlChangeFilters(vout_thread_t *vout, const char *filters)
{
    vout_control_PushString(&vout->p->control, VOUT_CONTROL_CHANGE_FILTERS,
                            filters);
}
558
void vout_ControlChangeSubSources(vout_thread_t *vout, const char *filters)
559
{
560
    vout_control_PushString(&vout->p->control, VOUT_CONTROL_CHANGE_SUB_SOURCES,
561 562
                            filters);
}
563 564 565 566 567
void vout_ControlChangeSubFilters(vout_thread_t *vout, const char *filters)
{
    vout_control_PushString(&vout->p->control, VOUT_CONTROL_CHANGE_SUB_FILTERS,
                            filters);
}
Laurent Aimar's avatar
Laurent Aimar committed
568 569 570 571 572
void vout_ControlChangeSubMargin(vout_thread_t *vout, int margin)
{
    vout_control_PushInteger(&vout->p->control, VOUT_CONTROL_CHANGE_SUB_MARGIN,
                             margin);
}
573

574 575 576 577
/* */
static void VoutGetDisplayCfg(vout_thread_t *vout, vout_display_cfg_t *cfg, const char *title)
{
    /* Load configuration */
578 579
    cfg->is_fullscreen = var_CreateGetBool(vout, "fullscreen")
                         || var_InheritBool(vout, "video-wallpaper");
580 581 582 583 584 585
    cfg->display.title = title;
    const int display_width = var_CreateGetInteger(vout, "width");
    const int display_height = var_CreateGetInteger(vout, "height");
    cfg->display.width   = display_width > 0  ? display_width  : 0;
    cfg->display.height  = display_height > 0 ? display_height : 0;
    cfg->is_display_filled  = var_CreateGetBool(vout, "autoscale");
586 587 588 589 590 591 592 593
    unsigned msar_num, msar_den;
    if (var_InheritURational(vout, &msar_num, &msar_den, "monitor-par") ||
        msar_num <= 0 || msar_den <= 0) {
        msar_num = 1;
        msar_den = 1;
    }
    cfg->display.sar.num = msar_num;
    cfg->display.sar.den = msar_den;
594 595 596 597 598 599 600 601 602 603 604 605 606
    unsigned zoom_den = 1000;
    unsigned zoom_num = zoom_den * var_CreateGetFloat(vout, "scale");
    vlc_ureduce(&zoom_num, &zoom_den, zoom_num, zoom_den, 0);
    cfg->zoom.num = zoom_num;
    cfg->zoom.den = zoom_den;
    cfg->align.vertical = VOUT_DISPLAY_ALIGN_CENTER;
    cfg->align.horizontal = VOUT_DISPLAY_ALIGN_CENTER;
    const int align_mask = var_CreateGetInteger(vout, "align");
    if (align_mask & 0x1)
        cfg->align.horizontal = VOUT_DISPLAY_ALIGN_LEFT;
    else if (align_mask & 0x2)
        cfg->align.horizontal = VOUT_DISPLAY_ALIGN_RIGHT;
    if (align_mask & 0x4)
607
        cfg->align.vertical = VOUT_DISPLAY_ALIGN_TOP;
608
    else if (align_mask & 0x8)
609
        cfg->align.vertical = VOUT_DISPLAY_ALIGN_BOTTOM;
610 611
}

612
vout_window_t * vout_NewDisplayWindow(vout_thread_t *vout,
613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640
                                      const vout_window_cfg_t *cfg)
{
    vout_window_cfg_t cfg_override = *cfg;

    if (!var_InheritBool( vout, "embedded-video"))
        cfg_override.is_standalone = true;

    if (vout->p->window.is_unused && vout->p->window.object) {
        assert(!vout->p->splitter_name);
        if (!cfg_override.is_standalone == !vout->p->window.cfg.is_standalone &&
            cfg_override.type           == vout->p->window.cfg.type) {
            /* Reuse the stored window */
            msg_Dbg(vout, "Reusing previous vout window");
            vout_window_t *window = vout->p->window.object;
            if (cfg_override.width  != vout->p->window.cfg.width ||
                cfg_override.height != vout->p->window.cfg.height)
                vout_window_SetSize(window,
                                    cfg_override.width, cfg_override.height);
            vout->p->window.is_unused = false;
            vout->p->window.cfg       = cfg_override;
            return window;
        }

        vout_window_Delete(vout->p->window.object);
        vout->p->window.is_unused = true;
        vout->p->window.object    = NULL;
    }

641
    vout_window_t *window = vout_window_New(VLC_OBJECT(vout), "$window",
642 643 644 645 646 647 648 649 650 651 652
                                            &cfg_override);
    if (!window)
        return NULL;
    if (!vout->p->splitter_name) {
        vout->p->window.is_unused = false;
        vout->p->window.cfg       = cfg_override;
        vout->p->window.object    = window;
    }
    return window;
}

653
void vout_DeleteDisplayWindow(vout_thread_t *vout, vout_window_t *window)
654
{
655
    if (!vout->p->window.is_unused && vout->p->window.object == window) {
656
        vout->p->window.is_unused = true;
657 658 659 660 661
    } else if (vout->p->window.is_unused && vout->p->window.object && !window) {
        vout_window_Delete(vout->p->window.object);
        vout->p->window.is_unused = true;
        vout->p->window.object    = NULL;
    } else if (window) {
662
        vout_window_Delete(window);
663
    }
664 665
}

666
/* */
667
static picture_t *VoutVideoFilterInteractiveNewPicture(filter_t *filter)
668
{
669
    vout_thread_t *vout = filter->owner.sys;
670

671
    picture_t *picture = picture_pool_Get(vout->p->private_pool);
672 673
    if (picture) {
        picture_Reset(picture);
674
        VideoFormatCopyCropAr(&picture->format, &filter->fmt_out.video);
675
    }
676
    return picture;
677
}
678

679 680
static picture_t *VoutVideoFilterStaticNewPicture(filter_t *filter)
{
681
    vout_thread_t *vout = filter->owner.sys;
682 683 684 685

    vlc_assert_locked(&vout->p->filter.lock);
    if (filter_chain_GetLength(vout->p->filter.chain_interactive) == 0)
        return VoutVideoFilterInteractiveNewPicture(filter);
686

687 688
    return picture_NewFromFormat(&filter->fmt_out.video);
}
689

690 691 692 693 694
static void VoutVideoFilterDelPicture(filter_t *filter, picture_t *picture)
{
    VLC_UNUSED(filter);
    picture_Release(picture);
}
695

696
static void ThreadFilterFlush(vout_thread_t *vout, bool is_locked)
Laurent Aimar's avatar
Laurent Aimar committed
697 698 699 700 701 702 703 704 705
{
    if (vout->p->displayed.current)
        picture_Release( vout->p->displayed.current );
    vout->p->displayed.current = NULL;

    if (vout->p->displayed.next)
        picture_Release( vout->p->displayed.next );
    vout->p->displayed.next = NULL;

706 707
    if (!is_locked)
        vlc_mutex_lock(&vout->p->filter.lock);
Laurent Aimar's avatar
Laurent Aimar committed
708 709
    filter_chain_VideoFlush(vout->p->filter.chain_static);
    filter_chain_VideoFlush(vout->p->filter.chain_interactive);
710 711
    if (!is_locked)
        vlc_mutex_unlock(&vout->p->filter.lock);
Laurent Aimar's avatar
Laurent Aimar committed
712 713 714 715 716 717 718
}

typedef struct {
    char           *name;
    config_chain_t *cfg;
} vout_filter_t;

719 720 721 722
static void ThreadChangeFilters(vout_thread_t *vout,
                                const video_format_t *source,
                                const char *filters,
                                bool is_locked)
Laurent Aimar's avatar
Laurent Aimar committed
723
{
724
    ThreadFilterFlush(vout, is_locked);
Laurent Aimar's avatar
Laurent Aimar committed
725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755

    vlc_array_t array_static;
    vlc_array_t array_interactive;

    vlc_array_init(&array_static);
    vlc_array_init(&array_interactive);
    char *current = filters ? strdup(filters) : NULL;
    while (current) {
        config_chain_t *cfg;
        char *name;
        char *next = config_ChainCreate(&name, &cfg, current);

        if (name && *name) {
            vout_filter_t *e = xmalloc(sizeof(*e));
            e->name = name;
            e->cfg  = cfg;
            if (!strcmp(e->name, "deinterlace") ||
                !strcmp(e->name, "postproc")) {
                vlc_array_append(&array_static, e);
            } else {
                vlc_array_append(&array_interactive, e);
            }
        } else {
            if (cfg)
                config_ChainDestroy(cfg);
            free(name);
        }
        free(current);
        current = next;
    }

756 757 758
    if (!is_locked)
        vlc_mutex_lock(&vout->p->filter.lock);

Laurent Aimar's avatar
Laurent Aimar committed
759
    es_format_t fmt_target;
760
    es_format_InitFromVideo(&fmt_target, source ? source : &vout->p->filter.format);
Laurent Aimar's avatar
Laurent Aimar committed
761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783

    es_format_t fmt_current = fmt_target;

    for (int a = 0; a < 2; a++) {
        vlc_array_t    *array = a == 0 ? &array_static :
                                         &array_interactive;
        filter_chain_t *chain = a == 0 ? vout->p->filter.chain_static :
                                         vout->p->filter.chain_interactive;

        filter_chain_Reset(chain, &fmt_current, &fmt_current);
        for (int i = 0; i < vlc_array_count(array); i++) {
            vout_filter_t *e = vlc_array_item_at_index(array, i);
            msg_Dbg(vout, "Adding '%s' as %s", e->name, a == 0 ? "static" : "interactive");
            if (!filter_chain_AppendFilter(chain, e->name, e->cfg, NULL, NULL)) {
                msg_Err(vout, "Failed to add filter '%s'", e->name);
                config_ChainDestroy(e->cfg);
            }
            free(e->name);
            free(e);
        }
        fmt_current = *filter_chain_GetFmtOut(chain);
        vlc_array_clear(array);
    }
784

Laurent Aimar's avatar
Laurent Aimar committed
785 786 787 788 789 790 791 792 793 794
    if (!es_format_IsSimilar(&fmt_current, &fmt_target)) {
        msg_Dbg(vout, "Adding a filter to compensate for format changes");
        if (!filter_chain_AppendFilter(vout->p->filter.chain_interactive, NULL, NULL,
                                       &fmt_current, &fmt_target)) {
            msg_Err(vout, "Failed to compensate for the format changes, removing all filters");
            filter_chain_Reset(vout->p->filter.chain_static,      &fmt_target, &fmt_target);
            filter_chain_Reset(vout->p->filter.chain_interactive, &fmt_target, &fmt_target);
        }
    }

Hannes Domani's avatar
Hannes Domani committed
795 796
    es_format_Clean(&fmt_target);

797 798 799 800 801 802 803 804 805 806 807
    if (vout->p->filter.configuration != filters) {
        free(vout->p->filter.configuration);
        vout->p->filter.configuration = filters ? strdup(filters) : NULL;
    }
    if (source) {
        video_format_Clean(&vout->p->filter.format);
        video_format_Copy(&vout->p->filter.format, source);
    }

    if (!is_locked)
        vlc_mutex_unlock(&vout->p->filter.lock);
Laurent Aimar's avatar
Laurent Aimar committed
808 809
}

810

811
/* */
812
static int ThreadDisplayPreparePicture(vout_thread_t *vout, bool reuse, bool frame_by_frame)
Vincent Seguin's avatar
Vincent Seguin committed
813
{
814
    bool is_late_dropped = vout->p->is_late_dropped && !vout->p->pause.is_on && !frame_by_frame;
815

816
    vlc_mutex_lock(&vout->p->filter.lock);
817

818 819
    picture_t *picture = filter_chain_VideoFilter(vout->p->filter.chain_static, NULL);
    assert(!reuse || !picture);
820

821 822 823 824
    while (!picture) {
        picture_t *decoded;
        if (reuse && vout->p->displayed.decoded) {
            decoded = picture_Hold(vout->p->displayed.decoded);
825
        } else {
826
            decoded = picture_fifo_Pop(vout->p->decoder_fifo);
827 828 829 830 831 832 833 834 835 836 837 838
            if (decoded) {
                if (is_late_dropped && !decoded->b_force) {
                    const mtime_t predicted = mdate() + 0; /* TODO improve */
                    const mtime_t late = predicted - decoded->date;
                    if (late > VOUT_DISPLAY_LATE_THRESHOLD) {
                        msg_Warn(vout, "picture is too late to be displayed (missing %"PRId64" ms)", late/1000);
                        picture_Release(decoded);
                        vout_statistic_AddLost(&vout->p->statistic, 1);
                        continue;
                    } else if (late > 0) {
                        msg_Dbg(vout, "picture might be displayed late (missing %"PRId64" ms)", late/1000);
                    }
839
                }
840 841
                if (!VideoFormatIsCropArEqual(&decoded->format, &vout->p->filter.format))
                    ThreadChangeFilters(vout, &decoded->format, vout->p->filter.configuration, true);
842
            }
843
        }
844

845 846 847
        if (!decoded)
            break;
        reuse = false;
848

849 850 851 852 853
        if (vout->p->displayed.decoded)
            picture_Release(vout->p->displayed.decoded);

        vout->p->displayed.decoded       = picture_Hold(decoded);
        vout->p->displayed.timestamp     = decoded->date;
854
        vout->p->displayed.is_interlaced = !decoded->b_progressive;
855 856

        picture = filter_chain_VideoFilter(vout->p->filter.chain_static, decoded);
857 858
    }

859 860 861 862
    vlc_mutex_unlock(&vout->p->filter.lock);

    if (!picture)
        return VLC_EGENERIC;
863

864 865 866 867 868 869
    assert(!vout->p->displayed.next);
    if (!vout->p->displayed.current)
        vout->p->displayed.current = picture;
    else
        vout->p->displayed.next    = picture;
    return VLC_SUCCESS;
870 871
}

872
static int ThreadDisplayRenderPicture(vout_thread_t *vout, bool is_forced)
873
{
874
    vout_thread_sys_t *sys = vout->p;
875 876
    vout_display_t *vd = vout->p->display.vd;

877
    picture_t *torender = picture_Hold(vout->p->displayed.current);
878

879
    vout_chrono_Start(&vout->p->render);
880

881 882 883 884 885 886 887 888 889 890 891
    vlc_mutex_lock(&vout->p->filter.lock);
    picture_t *filtered = filter_chain_VideoFilter(vout->p->filter.chain_interactive, torender);
    vlc_mutex_unlock(&vout->p->filter.lock);

    if (!filtered)
        return VLC_EGENERIC;

    if (filtered->date != vout->p->displayed.current->date)
        msg_Warn(vout, "Unsupported timestamp modifications done by chain_interactive");

    /*
892
     * Get the subpicture to be displayed
893 894
     */
    const bool do_snapshot = vout_snapshot_IsRequested(&vout->p->snapshot);
895
    mtime_t render_subtitle_date;
896
    if (vout->p->pause.is_on)
897
        render_subtitle_date = vout->p->pause.date;
898
    else
899 900 901
        render_subtitle_date = filtered->date > 1 ? filtered->date : mdate();
    mtime_t render_osd_date = mdate(); /* FIXME wrong */

902 903 904 905 906 907
    /*
     * Get the subpicture to be displayed
     */
    const bool do_dr_spu = !do_snapshot &&
                           vd->info.subpicture_chromas &&
                           *vd->info.subpicture_chromas != 0;
908 909 910 911 912

    //FIXME: Denying do_early_spu if vd->source.orientation != ORIENT_NORMAL
    //will have the effect that snapshots miss the subpictures. We do this
    //because there is currently no way to transform subpictures to match
    //the source format.
913
    const bool do_early_spu = !do_dr_spu &&
914
                               vd->source.orientation == ORIENT_NORMAL &&
915 916 917 918 919 920
                              (vd->info.is_slow ||
                               sys->display.use_dr ||
                               do_snapshot ||
                               !vout_IsDisplayFiltered(vd) ||
                               vd->fmt.i_width * vd->fmt.i_height <= vd->source.i_width * vd->source.i_height);

921 922 923
    const vlc_fourcc_t *subpicture_chromas;
    video_format_t fmt_spu;
    if (do_dr_spu) {
924 925 926 927 928 929 930 931 932 933 934 935
        vout_display_place_t place;
        vout_display_PlacePicture(&place, &vd->source, vd->cfg, false);

        fmt_spu = vd->source;
        if (fmt_spu.i_width * fmt_spu.i_height < place.width * place.height) {
            fmt_spu.i_sar_num = vd->cfg->display.sar.num;
            fmt_spu.i_sar_den = vd->cfg->display.sar.den;
            fmt_spu.i_width          =
            fmt_spu.i_visible_width  = place.width;
            fmt_spu.i_height         =
            fmt_spu.i_visible_height = place.height;
        }
936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960
        subpicture_chromas = vd->info.subpicture_chromas;
    } else {
        if (do_early_spu) {
            fmt_spu = vd->source;
        } else {
            fmt_spu = vd->fmt;
            fmt_spu.i_sar_num = vd->cfg->display.sar.num;
            fmt_spu.i_sar_den = vd->cfg->display.sar.den;
        }
        subpicture_chromas = NULL;

        if (vout->p->spu_blend &&
            vout->p->spu_blend->fmt_out.video.i_chroma != fmt_spu.i_chroma) {
            filter_DeleteBlend(vout->p->spu_blend);
            vout->p->spu_blend = NULL;
            vout->p->spu_blend_chroma = 0;
        }
        if (!vout->p->spu_blend && vout->p->spu_blend_chroma != fmt_spu.i_chroma) {
            vout->p->spu_blend_chroma = fmt_spu.i_chroma;
            vout->p->spu_blend = filter_NewBlend(VLC_OBJECT(vout), &fmt_spu);
            if (!vout->p->spu_blend)
                msg_Err(vout, "Failed to create blending filter, OSD/Subtitles will not work");
        }
    }

961
    video_format_t fmt_spu_rot;
962
    video_format_ApplyRotation(&fmt_spu_rot, &fmt_spu);
963
    subpicture_t *subpic = spu_Render(vout->p->spu,
964
                                      subpicture_chromas, &fmt_spu_rot,
965
                                      &vd->source,
966 967
                                      render_subtitle_date, render_osd_date,
                                      do_snapshot);
968 969 970 971 972 973 974
    /*
     * Perform rendering
     *
     * We have to:
     * - be sure to end up with a direct buffer.
     * - blend subtitles, and in a fast access buffer
     */
975 976 977
    bool is_direct = vout->p->decoder_pool == vout->p->display_pool;
    picture_t *todisplay = filtered;
    if (do_early_spu && subpic) {
978 979 980 981
        picture_t *blent = picture_pool_Get(vout->p->private_pool);
        if (blent) {
            VideoFormatCopyCropAr(&blent->format, &filtered->format);
            picture_Copy(blent, filtered);
982 983
            if (vout->p->spu_blend
             && picture_BlendSubpicture(blent, vout->p->spu_blend, subpic)) {
984 985 986 987
                picture_Release(todisplay);
                todisplay = blent;
            } else
                picture_Release(blent);
Sam Hocevar's avatar
 
Sam Hocevar committed
988
        }
989 990 991 992
        subpicture_Delete(subpic);
        subpic = NULL;
    }

993 994 995 996 997 998 999 1000
    assert(vout_IsDisplayFiltered(vd) == !sys->display.use_dr);
    if (sys->display.use_dr && !is_direct) {
        picture_t *direct = picture_pool_Get(vout->p->display_pool);
        if (!direct) {
            picture_Release(todisplay);
            if (subpic)
                subpicture_Delete(subpic);
            return VLC_EGENERIC;
1001
        }
Sam Hocevar's avatar
 
Sam Hocevar committed
1002

1003 1004 1005 1006 1007 1008 1009 1010
        /* The display uses direct rendering (no conversion), but its pool of
         * pictures is not usable by the decoder (too few, too slow or
         * subject to invalidation...). Since there are no filters, copying
         * pictures from the decoder to the output is unavoidable. */
        VideoFormatCopyCropAr(&direct->format, &todisplay->format);
        picture_Copy(direct, todisplay);
        picture_Release(todisplay);
        todisplay = direct;
1011
    }
1012

1013 1014 1015 1016
    /*
     * Take a snapshot if requested
     */
    if (do_snapshot)
1017
        vout_snapshot_Set(&vout->p->snapshot, &vd->source, todisplay);
Sam Hocevar's avatar
 
Sam Hocevar committed
1018

1019
    /* Render the direct buffer */
1020
    vout_UpdateDisplaySourceProperties(vd, &todisplay->format);
1021
    if (sys->display.use_dr) {
1022
        vout_display_Prepare(vd, todisplay, subpic);
1023
    } else {
1024
        sys->display.filtered = vout_FilterDisplay(vd, todisplay);
1025 1026 1027 1028 1029 1030
        if (sys->display.filtered) {
            if (!do_dr_spu && !do_early_spu && vout->p->spu_blend && subpic)
                picture_BlendSubpicture(sys->display.filtered, vout->p->spu_blend, subpic);
            vout_display_Prepare(vd, sys->display.filtered, do_dr_spu ? subpic : NULL);
        }
        if (!do_dr_spu && subpic)
1031
        {
1032
            subpicture_Delete(subpic);
1033 1034
            subpic = NULL;
        }
1035 1036
        if (!sys->display.filtered)
            return VLC_EGENERIC;
1037
    }
1038 1039

    vout_chrono_Stop(&vout->p->render);
1040
#if 0
1041 1042 1043 1044 1045
        {
        static int i = 0;
        if (((i++)%10) == 0)
            msg_Info(vout, "render: avg %d ms var %d ms",
                     (int)(vout->p->render.avg/1000), (int)(vout->p->render.var/1000));
1046
        }
1047 1048 1049 1050 1051 1052 1053 1054 1055
#endif

    /* Wait the real date (for rendering jitter) */
#if 0
    mtime_t delay = direct->date - mdate();
    if (delay < 1000)
        msg_Warn(vout, "picture is late (%lld ms)", delay / 1000);
#endif
    if (!is_forced)
1056
        mwait(todisplay->date);
1057

1058 1059
    /* Display the direct buffer returned by vout_RenderPicture */
    vout->p->displayed.date = mdate();
1060 1061
    vout_display_Display(vd,
                         sys->display.filtered ? sys->display.filtered
1062
                                                : todisplay,
1063
                         subpic);
1064
    sys->display.filtered = NULL;
1065

1066
    vout_statistic_AddDisplayed(&vout->p->statistic, 1);
1067 1068 1069

    return VLC_SUCCESS;
}
Vincent Seguin's avatar
Vincent Seguin committed
1070

1071
static int ThreadDisplayPicture(vout_thread_t *vout, mtime_t *deadline)
1072
{
1073 1074
    bool frame_by_frame = !deadline;
    bool paused = vout->p->pause.is_on;
1075
    bool first = !vout->p->displayed.current;
1076 1077 1078 1079 1080 1081 1082 1083

    if (first)
        if (ThreadDisplayPreparePicture(vout, true, frame_by_frame)) /* FIXME not sure it is ok */
            return VLC_EGENERIC;

    if (!paused || frame_by_frame)
        while (!vout->p->displayed.next && !ThreadDisplayPreparePicture(vout, false, frame_by_frame))
            ;
Vincent Seguin's avatar
Vincent Seguin committed
1084

1085 1086 1087
    const mtime_t date = mdate();
    const mtime_t render_delay = vout_chrono_GetHigh(&vout->p->render) + VOUT_MWAIT_TOLERANCE;

1088
    bool drop_next_frame = frame_by_frame;
1089
    mtime_t date_next = VLC_TS_INVALID;
1090
    if (!paused && vout->p->displayed.next) {
1091
        date_next = vout->p->displayed.next->date - render_delay;
1092 1093 1094
        if (date_next /* + 0 FIXME */ <= date)
            drop_next_frame = true;
    }
1095 1096 1097

    /* FIXME/XXX we must redisplay the last decoded picture (because
     * of potential vout updated, or filters update or SPU update)
1098
     * For now a high update period is needed but it could be removed