Gijs Peskens authored Feb 16, 2021 and Sergio Ammirata committed Feb 16, 2021

Refactor clock_gettime support for Darwin to fix compilation problems for older OSes

Add stats for sender max bandwidth skips and provide max bandwidth protection for congestion control off mode.

Gijs Peskens authored Dec 31, 2020 and Sergio Ammirata committed Jan 01, 2021

When we receive a echo request we (correctly) assume receiver supports echo requests, and disable RTT calculation via SR-RR packets, however we don't start sending echo requests, this corrects that so we do send them.

Use the correct dynamic rtt for retries on sender and change agressive congestion control to allow more retries (2*RTT spacing on them)

* remove unnecesary chain of functions.
* nacks moved to flow, instead of per peer
* handle peer timeout on receiver

Incorrectly logging old sequence numbers if nack count is less than 4

Use the message structures and protocol of EAP-SRP while using SRP-6a
for the actual key exchange.

* Many bugfixes
-- most importantly fixing clock drift issues, causing packet loss when receiving clock is running to fast and "no more buffer time is left"
--don't use non blocking send on receiver data output
* Feature Null packet deletion, automatically detected on receiver, ability to turn on on sender via CLI argument
* Minor features:
--cumulative stats in receiver
--ability to calculate RTT based of XR packets (Upipe uses those)
--calculate retry deadline based on expected arrival times
--set high priority on receiver data output threads (prevents certain issues)
--log average time spend in buffer of packets

Nonce should not be generated by generate_flowid function as it sets the LSB to 0
effectively setting the nonce to 31 bits of random data.
Also rand() was not being properly seeded.

Make the required changes in meson.config file for building via subproject
Allow turning off of mbedtls if desired

Allows for accelerated AES on more platforms beside linux, as well as
DTLS support which we can work on for future release.

TODO:
- work out meson logic, test against encryption via linux crypto
and C AES.
- add mbedtls as a subproject in meson and have it build in case library
  is not available (i.e.: Windows builds)

Gijs Peskens authored Sep 03, 2020 and Sergio Ammirata committed Sep 10, 2020

Also move lots of logging to debug

Still might need to keep more counters and print them from within an interval timer

During interop testing it has been discovered we're sending the sequence extension RTCP header with unitialized values.
Disable it for now, as we currently do not support sequence extension at all.

This fixes a potential security issue where IV's can be reused and data could potentially be intercepted.
Also fixes intermittent decryption error condition in encryption test case when linux_crypto is enabled.

Peers were not getting associated correctly, so their NACKS were getting ignored, this corrects that.

Future TODO: we need to be compliant with the spec, which means listening for RTCP comms on multicast,
instead of the unicast source we send from. Also for the receiver we will need to be able to send to the
RTCP multicast, instead of it's unicast source.
Other implementations also have this behaviour, so we will need to figure a way to do both in a sensible
way to remain compatible.

Allow both sender and receiver to generate packet loss on their outgoing packets, to be used in testing.

Fix packets not being recovered in simple profile as well as crashing under higher packet loss

Change the default behavior to perform transfers without using multiplexing/demultiplexing rules (it makes it more friendly to non-librist peers)

Switch all recvfrom and sendto socket calls to be non-blocking for higher performance and reliability (poll will still block and maintain timing)

When I try to compile against musl libc on Ubuntu 20.04, linux/if_alg.h
is not available.

This change simply uses the fallback code if the header isn't found at
configure-time.

I'm not sure if there's some missing package that would provide this.  I
searched but did not spot a candidate.