GitLab

François Cartegnie authored Jun 01, 2021 and Jean-Baptiste Kempf committed Jun 02, 2021

refs #25781

François Cartegnie authored May 31, 2021 and Hugo Beauzée-Luyssen committed Jun 01, 2021

ends up reading wrong sample size/time

refs #25784

'cat hints' should only be used by the core (to define a set of
headings to break its large set of options up with, instead of the
option tree items).

incorrectly using a cat hint here instead of a section means that this
"hacks" sub-heading gets printed like a module heading, which is both
imperfect from a neatness point of view, but also and more importantly
potentially confusing.

François Cartegnie authored May 18, 2021 and Jean-Baptiste Kempf committed May 19, 2021

some transmit empty <50 bytes data object

François Cartegnie authored May 03, 2021 and Jean-Baptiste Kempf committed May 19, 2021

Having to deal with es_Add or Del sequences forces the command
queue to expect another type of input on the esout before
recycling es, creating delay in multiple cases.

Lyndon Brown authored Mar 23, 2019 and Jean-Baptiste Kempf committed May 12, 2021

where identical to shorttext, or near enough.

bad because:
 - wastes resources.
 - useless tooltips in prefs GUI (poor UX) - tooltip longtext should add
   something of value.
 - useless repetition of text in certain help output.

in some cases they differed only in full-stop, creating unnecessary extra
burden on translators.

Marvin Scholz authored Oct 08, 2020 and Jean-Baptiste Kempf committed Apr 28, 2021

Stream re-use could never happen, as p_stream->p_es is always NULL
here, as implied by the earlier check:

   if ( p_stream->p_es == NULL && !p_stream->b_finished )

To fix that, the check for a non-null p_stream->p_es is removed.

Partially fixes #25186

François Cartegnie authored Apr 12, 2021 and Hugo Beauzée-Luyssen committed Apr 27, 2021

could trigger -1 offset move

reported by Zhen Zhou of NSFOCUS Security Team

regression regarding #24237 after chunk probe only change

Since the variable is set just after.