Do not declare *_sys_t typedefs globally in vlc_common.h. Instead,
declare them locally in each module that provides a definition.

This paves the way to move C++ definitions into anonymous namespaces in
order to respect C++ ODR.

The picture_resource_t and sout_stream_id_sys_t typedefs will be handled
separately, since they require specific additional changes.

See #18033
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

See #17078
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

The implementation of vnc_encrypt_bytes called by vnc_connect needs to add a
return value check on function gcry_cipher_open.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Font alpha is 8-bits, not 32-bits.

This only ever contained a single helper function.

../../modules/spu/remoteosd.c: In function ‘vnc_connect’:
../../modules/spu/remoteosd.c:363:5: warning: ‘strncpy’ output truncated before terminating nul copying 12 bytes from a string of the same length [-Wstringop-truncation]
     strncpy(pv, "RFB 003.003\n", sz_rfbProtocolVersionMsg);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Michał Trzebiatowski <michtrz@gmail.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

This value is used as an unsigned in the vout and therefore causes an overflow
when the alignement contains SUBPICTURE_ALIGN_LEFT, which as the result of
having a text displayed at 426xxx in x. This value is supposed to be the
relative position from the alignement, and should therefore be 0 (as it always
is when opening the module and retrieving the alignement).
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

The function does not open MRLs, as correctly described in its
documentation, as such it is rather unfortunate that its name uses MRL
instead of URL (especially given that it cannot handle MRLs).

These changes are simply renaming all occurrences of the function, so
that the behavior of the function is properly reflected by its name.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>