GitLab

Do not declare *_sys_t typedefs globally in vlc_common.h. Instead,
declare them locally in each module that provides a definition.

This paves the way to move C++ definitions into anonymous namespaces in
order to respect C++ ODR.

The picture_resource_t and sout_stream_id_sys_t typedefs will be handled
separately, since they require specific additional changes.

See #18033
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

A combined access-demux cannot be instantiated without an ES output.
This checks that the ES output is present, avoiding crashes for
instance with vlc_stream_NewURL().

In order to avoid confusion with future vlc_alloc.

Also fix indentation.

The if-statement is redundant given that the loop-condition will not
fire unless the former if-condition is true; as such the if-condition
is now removed.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

These changes simply removes unnecessary/trailing whitespace, as well
as fixing a few issues with indentation.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Re-license almost all the playback modules to LGPLv2.1+ with
authorization from their respective contributors (230+)

This includes:
 - access, codec, packetizers, demux
 - audio filters, audio mixers, audio output
 - video filters, video chroma, video output
 - text renderers
 - XML parser
 - ARM NEON and SSE2 optimisations (mostly for chromas and filters)

Some modules are not concerned:
 - BDA and DShow access modules because Manol Manolov is AWOL
 - Real RTSP, because it is derived from Xine
 - x264 and t140 because they are encoders only
 - DLL Loader, because it is derived from MPlayer
 - DTS packetizer, because Jon Lech Johansen is AWOL
 - Shine and WMAfixed, because they are derived from Rockbox
 - Real demuxer, as it is derived from MPlayer and Wang Bo is AWOL
 - MPC demuxer, as Yavor Doganov is AWOL
 - Tivo demuxer, because it is derived from an MPlayer fork
 - Playlist demuxer, (WPL and ZPL parts missing), because suheaven is AWOL
 - iOS audio output and video display, because author refuses the license change
 - Equalizer and compressor, because Ronald Wright is AWOL
 - Mono, Headphone and Dolby, because author refuses the license change
 - hqdn3d and yadif, because they are from MPlayer/libavfilter
 - remoteosd, because it derives from RealVNC code
 - MMX optimisations, because Ollie Lho, from SiS, is AWOL
 - Rotate, because it depends on GPL motion

Nota Bene:
 - Some modules depend on GPL-only libraries, a LGPL module does not mean
   that the resulting binary module will be LGPL.
   Libraries affected would include liba52, libdvdcss, libdvdnav, libdvdread,
   faad2, libdca, libmad, libmpeg2, libpostproc, SRC, sid, zvbi and probably others.

Especially, when it is deprecated since a very long time.

This commit may eat your domestic pets.

When you try to capture from JACK, this is only possible with the
"oldstyle" jackd-0.x. If you want to use the newer, SMP-capable jack2,
the VLC inputs cannot be connected:

Cannot connect ports owned by inactive clients: "vlc-input-26611" is not
active
Cannot connect ports owned by inactive clients: "vlc-input-26611" is not
active

Unlike jack1, jack2 expects the process callback function to return 0.

The attached patch fixes this problem. It's been already fixed the same
way in the jack output plugin (see modules/audio_output/jack.c:290).

Taken from Debian bug #532339
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=532339)
Signed-off-by: Christophe Mutricy <xtophe@videolan.org>

Replace argument = realloc( argument, size ); with realloc_or_free() in modules/*, and while at it add assert( argument ) to mark unhandled ENOMEM conditions, also for malloc().

 There will be some regressions, I used automatic sed replacement with manual
checks but there was a lot to change.
 It's only the first pass.

Those multi-lines are still to be done (it's going to be fun...)
See also 5af4cc85.